Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Missing Test IDs for PDF components #2988

Open
kneerose opened this issue Feb 14, 2025 · 1 comment
Open

🐛 Missing Test IDs for PDF components #2988

kneerose opened this issue Feb 14, 2025 · 1 comment
Assignees
Labels

Comments

@kneerose
Copy link
Contributor

Context & versions

  • Some Several components lack proper test IDs, impeding effective testing and automation

Missing test IDs

1. Proposal Details

  • Abstract Content -> data-testid=abstract-content
  • Motivation Content -> data-testid=motivation-content
  • Rationale Content -> data-testid=rationale-content
  • Link text content -> data-testid=link-${index}-text-content

Image

2. Sort button

  • Missing Test ID: data-testid="sort-button"
    Image

3. Constitution URL error text

  • Current ID: prop=constitution-url-text-error (Incorrect Format)
    Suggested Correction: data-testid="prop-constitution-url-text-error" for consistency and clarity.
    Image
@kneerose kneerose changed the title 🐛 Missing Test IDs on PDF 🐛 Missing Test IDs for PDF components Feb 14, 2025
@kneerose kneerose added 🐛 Bug Something isn't working 🕵️‍♂️ Testing labels Feb 14, 2025
@nebojsact nebojsact moved this to To do in Govtool all Feb 18, 2025
@nebojsact nebojsact moved this from To do to In QA in Govtool all Feb 19, 2025
@kneerose
Copy link
Contributor Author

@nebojsact , the test ID for Link content is inaccurate. The link-${index}-text-content index is not set. Additionally, there is already a test ID for the link input. so you can remove the button testid, but keep the <p> tag test ID as it is.

Image

  • Also, please use subcomment-${id}-content on the <p> tag where the actual reply text is added, instead of applying it to the entire reply <div>.

Image

CC: @bosko-m

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: No status
Status: In QA
Development

No branches or pull requests

2 participants