This issue was moved to a discussion.
You can continue the conversation there. Go to discussion →
Investigate tech debt and address proposed best practices #72
Labels
You can continue the conversation there. Go to discussion →
Copied as a backup
+1 for switching to yarn 💪
Regarding tech debt - we had a meeting with frontend guys and they pointed out:
I18n integration - to avoid strings that are in many places duplicated (and gradually migrate them to some kind of application content storage).
Unification of consts (currently application have checks of types to string eg. https://github.com/IntersectMBO/govtool/blob/f66591ab7156fe80996f5addf2de8356463365f3/src/vva-fe/src/context/wallet.tsx#L337C18-L337C18).
Inline styles and duplicate components if there are any (needs investigation).
Eslint, tsc, husky to have the unified code style and checks on commit.
Wallet refactor - 1.2k of lines seems to be impossible to refactor at once but as it is one of the most crucial parts of the application I think that we should take care of designing the architecture for that module and again - gradually improve that file to increase the readability and maintainability.
Also - @JanJaroszczak provided [#81] configure unit tests with vitest #58 with initial unit tests that are also a good starting point for any other unit tests that might be added to github actions.
The text was updated successfully, but these errors were encountered: