Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FindChildCategories not finding sub categories of the current one #5

Open
icedocemile opened this issue Apr 13, 2017 · 1 comment
Open

Comments

@icedocemile
Copy link

Hi,

In function CategoryRepository#findChildCategoriesNamesAndIds, to find nested categories the SQL query include that condition :
AND c.id_parent > '.(int)$category->id.'

Which is wrong, because a subcategory dosn't significate the category ID is greater.
I strongly suggest you use the native function :
Category::getNestedCategories

This will returns the right ones.

@rokaszygmantas
Copy link
Member

Hello @icedocemile, thank you for feedback. As we are not working on Brad project so frequently, please don't hesitate to make a pull request with a fix proposal - it would be greatly appreciated! Have a nice day.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants