Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Back button causes CommandPanels items to be interactable #922

Open
slash1div opened this issue Nov 16, 2024 · 3 comments
Open

Back button causes CommandPanels items to be interactable #922

slash1div opened this issue Nov 16, 2024 · 3 comments
Assignees
Labels
bug Something isn't working confirmed A verified issue that is worked on enhancement New feature or request high

Comments

@slash1div
Copy link

Steps to Reproduce

  1. Install IridiumSkyblock on a server with CommandPanels.
  2. Make a commandpanels item that runs a menu command like "island border"
  3. Click the back button.
  4. Shift click the items
  5. Exit the menu then place the item, or drop the items then rejoin
  6. After rejoining, you can pick up the dropped items and the placed blocks are still there.

Expected Behavior

The menu should have the same behavior as before, where clicking or shift clicking interacts with the buttons.

Actual Behavior

The menu acts like a chest. You can take items and they will function, although moving them around in the inventory or leaving the game with them in your inventory will make them disappear. Placing or dropping the items on the ground, rejoining, then picking them up makes them stay.

Screenshots

8mb.video-9ou-l63Xtvzl.mp4

Server Software & Minecraft Version

git-Purpur-2176 (MC: 1.20.4)* You are running the latest version

IridiumSkyblock version

4.0.9.1

Server logs

No error messages: https://mclo.gs/2Fbxlru

Additional Comments

Viaversion and Viabackwards have been uninstalled.

Command arguments for the item in the menu are:

sudo= island border
cpc

Issue will happen regardless of cpc being added.

@slash1div slash1div added bug Something isn't working unconfirmed An issue that needs further investigation labels Nov 16, 2024
@PeachesMLG
Copy link
Member

This would be a bug with CommandPanels, not us. All we do is open the same inventory instance that was open before.

You can either disable this feature in the config (Honestly cant remember if this was configurable or not, but look around)

Or CommandPanels would have to fix this on their side

@slash1div
Copy link
Author

I was told to open an issue by sh0inx in the Discord as it's an issue that would most likely happen with some other plugins like shops.

Also, the back button is not removable and will stay there even if it's set to air.

@boiscljo boiscljo reopened this Nov 17, 2024
@PeachesMLG
Copy link
Member

Right, if there isnt an option to disable it we can add that fairly easily

@sh0inx sh0inx added enhancement New feature or request confirmed A verified issue that is worked on and removed unconfirmed An issue that needs further investigation labels Nov 20, 2024
@PeachesMLG PeachesMLG assigned PeachesMLG and unassigned sh0inx, PeachesMLG and dlsf Dec 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working confirmed A verified issue that is worked on enhancement New feature or request high
Projects
None yet
Development

No branches or pull requests

5 participants