Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Horizon Fix #926

Open
sh0inx opened this issue Nov 20, 2024 · 0 comments
Open

Horizon Fix #926

sh0inx opened this issue Nov 20, 2024 · 0 comments
Assignees
Labels
enhancement New feature or request low

Comments

@sh0inx
Copy link
Contributor

sh0inx commented Nov 20, 2024

With the way that we currently generate worlds, Minecraft interprets them as a normal overworld. This is fine for normal gameplay purposes, but because the world does not have the superflat marker, it interprets the horizon as being at the regular level (60 ish).

Upon inclusion of 1.17, this has become somewhat of an eyesore, as our range now extends from approximately -60 to 312, meaning that 1/3 of the sky is now black.

My proposed fix is to implement a ProtocolLib hook through an optional dependency and modify the packet being sent to the player on login/respawn/world change to convince the client that the IridiumSkyblock world they're in is a superflat world. Not only does this have a minimized impact on performance, as we're only checking on infrequent events, but this adds compatibility for all current servers and can be toggled through the config if desired.

The problem:

  • ProtocolLib packets are different between versions, so we're going to have to implement version specific packeteering; should be simple enough.
  • I cannot find the packet to manipulate in 1.20. Paper's new mappings have made it easier to look for the packet, but it has proven elusive.
@sh0inx sh0inx added enhancement New feature or request low labels Nov 20, 2024
@sh0inx sh0inx self-assigned this Dec 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request low
Projects
None yet
Development

No branches or pull requests

1 participant