Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing the way Vault is handled #927

Open
boiscljo opened this issue Nov 25, 2024 · 0 comments
Open

Changing the way Vault is handled #927

boiscljo opened this issue Nov 25, 2024 · 0 comments
Labels
enhancement New feature or request low

Comments

@boiscljo
Copy link
Contributor

In https://github.com/Iridium-Development/IridiumSkyblock/blob/master/src/main/java/com/iridium/iridiumskyblock/IridiumSkyblock.java#L136
wrapping the economy in a subclass to avoid ClassNotFoundException on Economy.class would render Vault to a softDepends.
Vault is not used in any way shape or form like a required depends in the plugin and the wrapper could be enough to replace it.

Benefits:

  • If vault is not there the plugin would start (Disabling Deposit/Withdraw, wrapper would return 0 as balance)
  • Could provide a better warning/error message if Vault is missing

Cons:

  • Having a wrapper around calls to the economy
@sh0inx sh0inx added the enhancement New feature or request label Nov 25, 2024
@PeachesMLG PeachesMLG added the low label Dec 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request low
Projects
None yet
Development

No branches or pull requests

3 participants