Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow trailing slash in the PROXY_ENDPOINT. #16

Open
coltfred opened this issue Jul 7, 2020 · 1 comment
Open

Allow trailing slash in the PROXY_ENDPOINT. #16

coltfred opened this issue Jul 7, 2020 · 1 comment

Comments

@coltfred
Copy link
Member

coltfred commented Jul 7, 2020

We discovered that if you put a trailing slash in the PROXY_ENDPOINT then you'll end up with the TSP dumping ERRO Rejection(NotFound).

This is confusing to the consumer. We should just detect that the trailing slash is present and strip it when they create the client.

Also, we should log the URL that was attempted to be hit when we log a 404 so it's more obvious to see what URL was hit and why it wasn't successful.

@BobWall23
Copy link
Member

When done with this, create a ticket in the node TSC to do the work there as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants