Skip to content

Commit

Permalink
add missing types to Basics phphdoc
Browse files Browse the repository at this point in the history
  • Loading branch information
fgibaux committed Jul 10, 2023
1 parent 3536bfc commit d1bc799
Show file tree
Hide file tree
Showing 2 changed files with 15 additions and 15 deletions.
14 changes: 7 additions & 7 deletions src/Resources/Basics/Entity.php
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ abstract class Entity extends Resource
/**
* List the resource associated emails.
*
* @param $id
* @param int $id
* @param array $options
* @return Response
*/
Expand All @@ -36,8 +36,8 @@ public function emails($id, $options = [])
/**
* Add a follower to a resource.
*
* @param $id
* @param $user_id
* @param int $id
* @param int $user_id
* @return Response
*/
public function addFollower($id, $user_id)
Expand All @@ -48,8 +48,8 @@ public function addFollower($id, $user_id)
/**
* Delete a follower from a resource.
*
* @param $id
* @param $follower_id
* @param int $id
* @param int $follower_id
* @return Response
*/
public function deleteFollower($id, $follower_id)
Expand All @@ -60,8 +60,8 @@ public function deleteFollower($id, $follower_id)
/**
* Merge a resource with another.
*
* @param $id
* @param $merge_with_id
* @param int $id
* @param int $merge_with_id
* @return Response
*/
public function merge($id, $merge_with_id)
Expand Down
16 changes: 8 additions & 8 deletions src/Resources/Basics/Resource.php
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ public function add(array $values)
/**
* Update an entity by ID.
*
* @param $id
* @param int $id
* @param array $values
* @return Response
*/
Expand All @@ -103,7 +103,7 @@ public function update($id, array $values)
/**
* Delete an entity by ID.
*
* @param $id
* @param int $id
* @return Response
*/
public function delete($id)
Expand Down Expand Up @@ -137,7 +137,7 @@ public function getName()
/**
* Check if the method is enabled for use.
*
* @param $method
* @param string $method
* @return bool
*/
public function isEnabled($method)
Expand All @@ -146,8 +146,8 @@ public function isEnabled($method)
return false;
}

// First we will make sure the method only belongs to this abtract class
// as this does not have to interfiere with methods described in child
// First we will make sure the method only belongs to this abstract class
// as this does not have to interfere with methods described in child
// classes. We can now check if it is found in the enabled property.
if (! in_array($method, get_class_methods(get_class()))) {
return true;
Expand All @@ -159,7 +159,7 @@ public function isEnabled($method)
/**
* Check if the method is disabled for use.
*
* @param $method
* @param string $method
* @return bool
*/
public function isDisabled($method)
Expand Down Expand Up @@ -208,8 +208,8 @@ public function setDisabled($disabled)
/**
* Magic method call.
*
* @param $method
* @param array $args
* @param string $method
* @param array $args
* @return void
* @throws PipedriveException
*/
Expand Down

0 comments on commit d1bc799

Please sign in to comment.