Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PATCH] Adding external authentication to Issabel #38

Open
marcogaio opened this issue Oct 10, 2022 · 1 comment
Open

[PATCH] Adding external authentication to Issabel #38

marcogaio opened this issue Oct 10, 2022 · 1 comment

Comments

@marcogaio
Copy link

[One year ago i've added this to the 'framework' project; i try also to add here, that seems at least have some feedback on bugs. Feel free to close this or that]
I've produced a patch/POC to enable in Issabel authentication using external sources. This patch is working in my production environment, but clearly need work to be integrated.

First patch modify login input, because i've not found a way to pass to authenticateUser() the non-md5 password; probably this is a big security hole (i suspect that the plaintext password is then saved to session cookie...) but it works.

index.php.diff.txt

Second patch modify authenticateUser() decoupling check for user existance in the db for the effective password check; i've addedd an LDAP/AD password check and an example, untested, code to login to an POP/IMAP server. Last i've keeped the original code that check against md5 password on the DB.

paloSantoACL.class.php.diff.txt

I'm seeking feedback, expecially for the security things.

Thanks.

@marcogaio
Copy link
Author

Sorry, forgot to link... original bugreport:
IssabelFoundation/framework#26
Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant