Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pearson correlation coefficient #42

Merged
merged 11 commits into from
Sep 30, 2023
Merged

Pearson correlation coefficient #42

merged 11 commits into from
Sep 30, 2023

Conversation

Tomko10
Copy link
Contributor

@Tomko10 Tomko10 commented Sep 29, 2023

Implemented Pearson correlation coefficient calculation on GPU.
Related: #35

@codecov
Copy link

codecov bot commented Sep 29, 2023 •
edited
Loading

Codecov Report

Merging #42 (74ea8bc) into master (8700a51) will decrease coverage by 0.60%.
Report is 14 commits behind head on master.
The diff coverage is 31.43%.

❗ Current head 74ea8bc differs from pull request most recent head d66c3dc. Consider uploading reports for the commit d66c3dc to get more accurate results

@@            Coverage Diff             @@
##           master      #42      +/-   ##
==========================================
- Coverage   88.22%   87.61%   -0.60%     
==========================================
  Files          66       67       +1     
  Lines        5100     5188      +88     
  Branches      927      946      +19     
==========================================
+ Hits         4499     4545      +46     
- Misses        411      448      +37     
- Partials      190      195       +5
Files Coverage Δ
pyecsca/sca/stacked_traces/combine.py 34.71% <32.26%> (+0.11%) ⬆️
pyecsca/sca/stacked_traces/correlate.py 30.77% <30.77%> (ø)

... and 4 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

J08nY
J08nY requested changes Sep 30, 2023
View reviewed changes
Copy link
Owner

@J08nY J08nY left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor changes required:

  • Property traces_shape
  • Docstring for intermed_sum, intermed_sq_sum
  • Test against np.corrcoeff to rule out implementation error.

pyecsca/sca/stacked_traces/combine.py Outdated Show resolved Hide resolved
pyecsca/sca/stacked_traces/correlate.py Show resolved Hide resolved
test/sca/test_stacked_correlate.py Show resolved Hide resolved
@J08nY J08nY merged commit 80c72fa into J08nY:master Sep 30, 2023
12 checks passed
@J08nY J08nY linked an issue Sep 30, 2023 that may be closed by this pull request
Implement correlation on GPU #35
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@J08nY J08nY J08nY approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement correlation on GPU
2 participants
@Tomko10 @J08nY