Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tox not passing environment variables #28

Closed
4word opened this issue May 24, 2016 · 2 comments
Closed

Tox not passing environment variables #28

4word opened this issue May 24, 2016 · 2 comments

Comments

@4word
Copy link
Contributor

4word commented May 24, 2016

Tests are failing in Travis because somehow, in the "passenv" section of the tox config, a leading dash is in front of the section name. Not sure how it snuck in, but it shouldn't be there and I believe its causing the tests to not test postgres or mysql specific code, since the default is sqlite if the environment variables are not found. It currently reads:

[testenv]
-passenv=
  DATABASE_URL
  SHARD_001_DATABASE_URL
  SHARD_002_DATABASE_URL
  REPLICA_001_DATABASE_URL
  REPLICA_002_DATABASE_URL
  TRAVIS

It should read

[testenv]
passenv=
  DATABASE_URL
  SHARD_001_DATABASE_URL
  SHARD_002_DATABASE_URL
  REPLICA_001_DATABASE_URL
  REPLICA_002_DATABASE_URL
  TRAVIS
@JBKahn
Copy link
Owner

JBKahn commented May 24, 2016 •
edited
Loading

ahhh I'll try to fix this tonight.

@4word
Copy link
Contributor Author

4word commented May 26, 2016 •
edited
Loading

I think this can be closed now, PR #29

@JBKahn JBKahn closed this as completed May 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@4word @JBKahn