From 20bfbc85f7fb2760e323b48d13e5040cf8bc677f Mon Sep 17 00:00:00 2001 From: wetao Date: Thu, 2 Jan 2025 15:53:30 +0800 Subject: [PATCH 1/4] #2119 add support INSERT OVERWRITE PARTITION --- pom.xml | 2 +- .../net/sf/jsqlparser/schema/Partition.java | 67 +++++++++++++++++++ .../jsqlparser/statement/insert/Insert.java | 43 +++++++++++- .../util/deparser/InsertDeParser.java | 16 ++++- .../net/sf/jsqlparser/parser/JSqlParserCC.jjt | 37 +++++++++- .../statement/insert/InsertTest.java | 34 +++++++++- 6 files changed, 194 insertions(+), 5 deletions(-) create mode 100644 src/main/java/net/sf/jsqlparser/schema/Partition.java diff --git a/pom.xml b/pom.xml index 8422095b4..91a95b69d 100644 --- a/pom.xml +++ b/pom.xml @@ -35,7 +35,7 @@ commons-io commons-io - [2.15.1,) + 2.18.0 test diff --git a/src/main/java/net/sf/jsqlparser/schema/Partition.java b/src/main/java/net/sf/jsqlparser/schema/Partition.java new file mode 100644 index 000000000..28b0cec45 --- /dev/null +++ b/src/main/java/net/sf/jsqlparser/schema/Partition.java @@ -0,0 +1,67 @@ +/*- + * #%L + * JSQLParser library + * %% + * Copyright (C) 2004 - 2025 JSQLParser + * %% + * Dual licensed under GNU LGPL 2.1 or Apache License 2.0 + * #L% + */ +package net.sf.jsqlparser.schema; + +import net.sf.jsqlparser.expression.Expression; + +import java.util.Collection; +import java.util.Objects; + +public class Partition { + protected Column column; + protected Expression value; + + public Partition() { + + } + + public Partition(Column column, Expression value) { + this.column = column; + this.value = value; + } + + public static StringBuilder appendPartitionsTo(StringBuilder builder, Collection partitions) { + int j = 0; + for (Partition partition : partitions) { + partition.appendTo(builder, j); + j++; + } + return builder; + } + + public Column getColumn() { + return column; + } + + public void setColumn(Column column) { + this.column = Objects.requireNonNull(column); + } + + public Expression getValue() { + return value; + } + + public void setValue(Expression value) { + this.value = Objects.requireNonNull(value); + } + + + @SuppressWarnings({"PMD.CyclomaticComplexity", "PMD.NPath"}) + StringBuilder appendTo(StringBuilder builder, int j) { + if (j > 0) { + builder.append(", "); + } + builder.append(column.getColumnName()); + if (value != null) { + builder.append(" = ").append(value); + } + return builder; + } +} diff --git a/src/main/java/net/sf/jsqlparser/statement/insert/Insert.java b/src/main/java/net/sf/jsqlparser/statement/insert/Insert.java index 4d52a5864..3351c7077 100644 --- a/src/main/java/net/sf/jsqlparser/statement/insert/Insert.java +++ b/src/main/java/net/sf/jsqlparser/statement/insert/Insert.java @@ -12,6 +12,7 @@ import net.sf.jsqlparser.expression.OracleHint; import net.sf.jsqlparser.expression.operators.relational.ExpressionList; import net.sf.jsqlparser.schema.Column; +import net.sf.jsqlparser.schema.Partition; import net.sf.jsqlparser.schema.Table; import net.sf.jsqlparser.statement.OutputClause; import net.sf.jsqlparser.statement.ReturningClause; @@ -36,11 +37,14 @@ public class Insert implements Statement { private Table table; private OracleHint oracleHint = null; private ExpressionList columns; + private List partitions; private Select select; private boolean onlyDefaultValues = false; private List duplicateUpdateSets = null; private InsertModifierPriority modifierPriority = null; private boolean modifierIgnore = false; + private boolean overwrite = false; + private boolean tableKeyword = false; private ReturningClause returningClause; private List setUpdateSets = null; private List> withItemsList; @@ -103,6 +107,14 @@ public void setColumns(ExpressionList list) { columns = list; } + public List getPartitions() { + return partitions; + } + + public void setPartitions(List list) { + partitions = list; + } + @Deprecated public boolean isUseValues() { return select != null && select instanceof Values; @@ -163,6 +175,22 @@ public void setModifierIgnore(boolean modifierIgnore) { this.modifierIgnore = modifierIgnore; } + public boolean isOverwrite() { + return overwrite; + } + + public void setOverwrite(boolean overwrite) { + this.overwrite = overwrite; + } + + public boolean isTableKeyword() { + return tableKeyword; + } + + public void setTableKeyword(boolean tableKeyword) { + this.tableKeyword = tableKeyword; + } + @Deprecated public boolean isUseSet() { return setUpdateSets != null && !setUpdateSets.isEmpty(); @@ -240,7 +268,14 @@ public String toString() { if (modifierIgnore) { sql.append("IGNORE "); } - sql.append("INTO "); + if (overwrite) { + sql.append("OVERWRITE "); + } else { + sql.append("INTO "); + } + if (tableKeyword) { + sql.append("TABLE "); + } sql.append(table).append(" "); if (onlyDefaultValues) { @@ -259,6 +294,12 @@ public String toString() { sql.append(") "); } + if (partitions != null) { + sql.append(" PARTITION ("); + Partition.appendPartitionsTo(sql, partitions); + sql.append(") "); + } + if (outputClause != null) { sql.append(outputClause); } diff --git a/src/main/java/net/sf/jsqlparser/util/deparser/InsertDeParser.java b/src/main/java/net/sf/jsqlparser/util/deparser/InsertDeParser.java index b9aa7bb65..5d30f4ec9 100644 --- a/src/main/java/net/sf/jsqlparser/util/deparser/InsertDeParser.java +++ b/src/main/java/net/sf/jsqlparser/util/deparser/InsertDeParser.java @@ -11,6 +11,7 @@ import net.sf.jsqlparser.expression.ExpressionVisitor; import net.sf.jsqlparser.schema.Column; +import net.sf.jsqlparser.schema.Partition; import net.sf.jsqlparser.statement.insert.Insert; import net.sf.jsqlparser.statement.select.Select; import net.sf.jsqlparser.statement.select.SelectVisitor; @@ -62,7 +63,14 @@ public void deParse(Insert insert) { if (insert.isModifierIgnore()) { buffer.append("IGNORE "); } - buffer.append("INTO "); + if (insert.isOverwrite()) { + buffer.append("OVERWRITE "); + } else { + buffer.append("INTO "); + } + if (insert.isTableKeyword()) { + buffer.append("TABLE "); + } buffer.append(insert.getTable().toString()); @@ -82,6 +90,12 @@ public void deParse(Insert insert) { buffer.append(")"); } + if (insert.getPartitions() != null) { + buffer.append(" PARTITION ("); + Partition.appendPartitionsTo(buffer, insert.getPartitions()); + buffer.append(")"); + } + if (insert.getOutputClause() != null) { buffer.append(insert.getOutputClause().toString()); } diff --git a/src/main/jjtree/net/sf/jsqlparser/parser/JSqlParserCC.jjt b/src/main/jjtree/net/sf/jsqlparser/parser/JSqlParserCC.jjt index efb7fe444..5c922a797 100644 --- a/src/main/jjtree/net/sf/jsqlparser/parser/JSqlParserCC.jjt +++ b/src/main/jjtree/net/sf/jsqlparser/parser/JSqlParserCC.jjt @@ -384,6 +384,7 @@ TOKEN: /* SQL Keywords. prefixed with K_ to avoid name clashes */ | | | +| | | | @@ -1602,6 +1603,33 @@ List UpdateSets(): } } +List Partitions(): +{ + List partitions = new ArrayList(); + Column tableColumn; + Expression valueExpression = null; +} +{ + ( + ( + tableColumn=Column() [ "=" valueExpression=Expression() ] + { partitions.add( new Partition (tableColumn, valueExpression)); } + ) + ) + + ( + LOOKAHEAD(2) ( + "," + tableColumn=Column() [ "=" valueExpression=Expression() ] + { partitions.add( new Partition (tableColumn, valueExpression)); } + ) + )* + + { + return partitions; + } +} + Insert InsertWithWithItems( List> withItems ): { Insert insert; @@ -1619,6 +1647,7 @@ Insert Insert(): List> with = null; Column tableColumn = null; ExpressionList columns = new ExpressionList(); + List partitions = new ArrayList(); Expression exp = null; ReturningClause returningClause; Select select = null; @@ -1626,6 +1655,8 @@ Insert Insert(): Token tk = null; InsertModifierPriority modifierPriority = null; boolean modifierIgnore = false; + boolean overwrite = false; + boolean tableKeyword = false; List updateSets; List duplicateUpdateSets; @@ -1648,7 +1679,8 @@ Insert Insert(): } ] [ LOOKAHEAD(2) { modifierIgnore = true; }] - [ LOOKAHEAD(2) ] table=Table() + [ LOOKAHEAD(2) ( | { insert.setOverwrite(true); }) [ { insert.setTableKeyword(true); }] ] table=Table() + [ LOOKAHEAD(2) "(" partitions=Partitions() ")" ] [ LOOKAHEAD(2) [ { useAs = true; } ] name=RelObjectNameWithoutValue() { table.setAlias(new Alias(name,useAs)); }] @@ -1682,6 +1714,9 @@ Insert Insert(): if (!columns.isEmpty()) { insert.setColumns(columns); } + if (!partitions.isEmpty()) { + insert.setPartitions(partitions); + } return insert.withWithItemsList(with) .withSelect(select) .withTable(table) diff --git a/src/test/java/net/sf/jsqlparser/statement/insert/InsertTest.java b/src/test/java/net/sf/jsqlparser/statement/insert/InsertTest.java index 421f6b629..13aae8862 100644 --- a/src/test/java/net/sf/jsqlparser/statement/insert/InsertTest.java +++ b/src/test/java/net/sf/jsqlparser/statement/insert/InsertTest.java @@ -401,7 +401,7 @@ public void testInsertSetWithDuplicateEliminationInDeparsing() throws JSQLParser @Test public void testInsertTableWithAliasIssue526() throws JSQLParserException { assertSqlCanBeParsedAndDeparsed( - "INSERT INTO account t (name, addr, phone) SELECT * FROM user"); + "INSERT INTO account AS t (name, addr, phone) SELECT * FROM user"); } @Test @@ -837,4 +837,36 @@ void testSelectAndInsertWithin2Ctes() throws JSQLParserException { assertEquals(" inserted", withItems.get(1).getAlias().toString()); } + @Test + void testInsertOverwrite() throws JSQLParserException { + String sqlStr = "INSERT OVERWRITE TABLE t SELECT * FROM a"; + Insert insert = (Insert) assertSqlCanBeParsedAndDeparsed(sqlStr); + assertEquals("t", insert.getTable().getName()); + assertTrue(insert.isOverwrite()); + + sqlStr = "INSERT OVERWRITE TABLE t PARTITION (pt1, pt2) SELECT * FROM a"; + insert = (Insert) assertSqlCanBeParsedAndDeparsed(sqlStr); + assertEquals("t", insert.getTable().getName()); + assertEquals(2, insert.getPartitions().size()); + assertEquals("pt1", insert.getPartitions().get(0).getColumn().getColumnName()); + assertNull(insert.getPartitions().get(0).getValue()); + assertTrue(insert.isOverwrite()); + + sqlStr = "INSERT OVERWRITE TABLE t PARTITION (pt1 = 'pt1', pt2 = 'pt2') SELECT * FROM a"; + insert = (Insert) assertSqlCanBeParsedAndDeparsed(sqlStr); + assertEquals("t", insert.getTable().getName()); + assertEquals(2, insert.getPartitions().size()); + assertEquals("pt2", insert.getPartitions().get(1).getColumn().getColumnName()); + assertEquals("'pt2'", insert.getPartitions().get(1).getValue().toString()); + assertTrue(insert.isOverwrite()); + + sqlStr = "INSERT INTO TABLE t PARTITION (pt1 = 'pt1', pt2 = 'pt2') SELECT * FROM a"; + insert = (Insert) assertSqlCanBeParsedAndDeparsed(sqlStr); + assertEquals("t", insert.getTable().getName()); + assertEquals(2, insert.getPartitions().size()); + assertEquals("pt1", insert.getPartitions().get(0).getColumn().getColumnName()); + assertEquals("'pt1'", insert.getPartitions().get(0).getValue().toString()); + assertFalse(insert.isOverwrite()); + } + } From 79fd199fe9007d0cb3968b8a1c74aa27c328d80d Mon Sep 17 00:00:00 2001 From: wetao Date: Fri, 3 Jan 2025 09:34:14 +0800 Subject: [PATCH 2/4] #2119 fix test case --- .../jjtree/net/sf/jsqlparser/parser/JSqlParserCC.jjt | 10 +++++++--- .../net/sf/jsqlparser/statement/insert/InsertTest.java | 4 ++-- 2 files changed, 9 insertions(+), 5 deletions(-) diff --git a/src/main/jjtree/net/sf/jsqlparser/parser/JSqlParserCC.jjt b/src/main/jjtree/net/sf/jsqlparser/parser/JSqlParserCC.jjt index 5c922a797..55a041ffd 100644 --- a/src/main/jjtree/net/sf/jsqlparser/parser/JSqlParserCC.jjt +++ b/src/main/jjtree/net/sf/jsqlparser/parser/JSqlParserCC.jjt @@ -1679,12 +1679,16 @@ Insert Insert(): } ] [ LOOKAHEAD(2) { modifierIgnore = true; }] - [ LOOKAHEAD(2) ( | { insert.setOverwrite(true); }) [ { insert.setTableKeyword(true); }] ] table=Table() + [ LOOKAHEAD(2) ( + { insert.setOverwrite(true); insert.setTableKeyword(true); } + | [ LOOKAHEAD(2) { insert.setTableKeyword(true); }] + ) + ] table=Table() [ LOOKAHEAD(2) "(" partitions=Partitions() ")" ] [ LOOKAHEAD(2) [ { useAs = true; } ] name=RelObjectNameWithoutValue() { table.setAlias(new Alias(name,useAs)); }] - [LOOKAHEAD(2) "(" columns=ColumnList() ")" ] + [ LOOKAHEAD(2) "(" columns=ColumnList() ")" ] [ outputClause = OutputClause() { insert.setOutputClause(outputClause); } ] @@ -2080,7 +2084,7 @@ String RelObjectNameWithoutValue() : { Token tk = null; } { ( tk= | tk= | tk= | tk= | tk= | tk= | tk= | tk= | tk= - | tk="ACTION" | tk="ACTIVE" | tk="ADD" | tk="ADVANCE" | tk="ADVISE" | tk="AGAINST" | tk="ALGORITHM" | tk="ALTER" | tk="ANALYZE" | tk="APPLY" | tk="APPROXIMATE" | tk="ARCHIVE" | tk="ARRAY" | tk="ASC" | tk="AT" | tk="AUTHORIZATION" | tk="AUTO" | tk="AUTO_INCREMENT" | tk="BASE64" | tk="BEGIN" | tk="BERNOULLI" | tk="BINARY" | tk="BIT" | tk="BLOCK" | tk="BROWSE" | tk="BUFFERS" | tk="BY" | tk="BYTE" | tk="BYTES" | tk="CACHE" | tk="CALL" | tk="CASCADE" | tk="CASE" | tk="CAST" | tk="CHANGE" | tk="CHANGES" | tk="CHAR" | tk="CHARACTER" | tk="CHECKPOINT" | tk="CLOSE" | tk="COLLATE" | tk="COLUMN" | tk="COLUMNS" | tk="COMMENT" | tk="COMMIT" | tk="CONCURRENTLY" | tk="CONFLICT" | tk="CONSTRAINTS" | tk="CONVERT" | tk="COSTS" | tk="COUNT" | tk="CS" | tk="CYCLE" | tk="DATA" | tk="DATABASE" | tk="DATETIME" | tk="DBA_RECYCLEBIN" | tk="DDL" | tk="DECLARE" | tk="DEFERRABLE" | tk="DELAYED" | tk="DELETE" | tk="DESC" | tk="DESCRIBE" | tk="DISABLE" | tk="DISCONNECT" | tk="DIV" | tk="DML" | tk="DO" | tk="DOMAIN" | tk="DROP" | tk="DUMP" | tk="DUPLICATE" | tk="ELEMENTS" | tk="EMIT" | tk="ENABLE" | tk="ENCRYPTION" | tk="END" | tk="ENGINE" | tk="ERROR" | tk="ESCAPE" | tk="EXCLUDE" | tk="EXEC" | tk="EXECUTE" | tk="EXPLAIN" | tk="EXPLICIT" | tk="EXTENDED" | tk="EXTRACT" | tk="FILTER" | tk="FIRST" | tk="FLUSH" | tk="FN" | tk="FOLLOWING" | tk="FORMAT" | tk="FULLTEXT" | tk="FUNCTION" | tk="GRANT" | tk="GROUP_CONCAT" | tk="GUARD" | tk="HASH" | tk="HIGH_PRIORITY" | tk="HISTORY" | tk="HOPPING" | tk="INCLUDE" | tk="INCLUDE_NULL_VALUES" | tk="INCREMENT" | tk="INDEX" | tk="INSERT" | tk="INTERLEAVE" | tk="INTERPRET" | tk="INVALIDATE" | tk="ISNULL" | tk="JSON" | tk="JSON_ARRAY" | tk="JSON_ARRAYAGG" | tk="JSON_OBJECT" | tk="JSON_OBJECTAGG" | tk="KEEP" | tk="KEY" | tk="KEYS" | tk="LAST" | tk="LEADING" | tk="LESS" | tk="LINK" | tk="LOCAL" | tk="LOCK" | tk="LOCKED" | tk="LOG" | tk="LONGTEXT" | tk="LOOP" | tk="LOW_PRIORITY" | tk="MATCH" | tk="MATCHED" | tk="MATCH_ALL" | tk="MATCH_ANY" | tk="MATCH_PHRASE" | tk="MATCH_PHRASE_PREFIX" | tk="MATCH_REGEXP" | tk="MATERIALIZED" | tk="MAX" | tk="MAXVALUE" | tk="MEDIUMTEXT" | tk="MEMBER" | tk="MERGE" | tk="MIN" | tk="MINVALUE" | tk="MODIFY" | tk="MOVEMENT" | tk="NEXT" | tk="NO" | tk="NOCACHE" | tk="NOKEEP" | tk="NOLOCK" | tk="NOMAXVALUE" | tk="NOMINVALUE" | tk="NOORDER" | tk="NOTHING" | tk="NOTNULL" | tk="NOVALIDATE" | tk="NOWAIT" | tk="NULLS" | tk="OF" | tk="OFF" | tk="OPEN" | tk="OVER" | tk="OVERFLOW" | tk="OVERLAPS" | tk="PARALLEL" | tk="PARENT" | tk="PARTITION" | tk="PATH" | tk="PERCENT" | tk="PLACING" | tk="PLAN" | tk="PRECEDING" | tk="PRIMARY" | tk="PURGE" | tk="QUERY" | tk="QUICK" | tk="QUIESCE" | tk="RANGE" | tk="RAW" | tk="READ" | tk="RECURSIVE" | tk="RECYCLEBIN" | tk="REFERENCES" | tk="REFRESH" | tk="REGEXP" | tk="REGEXP_LIKE" | tk="REGISTER" | tk="REMOTE" | tk="RENAME" | tk="REPEATABLE" | tk="REPLACE" | tk="RESET" | tk="RESPECT" | tk="RESTART" | tk="RESTRICT" | tk="RESTRICTED" | tk="RESUMABLE" | tk="RESUME" | tk="RETURN" | tk="RLIKE" | tk="ROLLBACK" | tk="ROLLUP" | tk="ROOT" | tk="ROW" | tk="ROWS" | tk="RR" | tk="RS" | tk="SAFE_CAST" | tk="SAVEPOINT" | tk="SCHEMA" | tk="SECURE" | tk="SEED" | tk="SEPARATOR" | tk="SEQUENCE" | tk="SESSION" | tk="SETS" | tk="SHARE" | tk="SHOW" | tk="SHUTDOWN" | tk="SIBLINGS" | tk="SIGNED" | tk="SIMILAR" | tk="SIZE" | tk="SKIP" | tk="STORED" | tk="STRING" | tk="STRUCT" | tk="SUMMARIZE" | tk="SUSPEND" | tk="SWITCH" | tk="SYNONYM" | tk="SYSTEM" | tk="TABLE" | tk="TABLESPACE" | tk="TEMP" | tk="TEMPORARY" | tk="TEXT" | tk="THAN" | tk="THEN" | tk="TIMEOUT" | tk="TIMESTAMPTZ" | tk="TIMEZONE" | tk="TINYTEXT" | tk="TO" | tk="TRIGGER" | tk="TRUNCATE" | tk="TRY_CAST" | tk="TUMBLING" | tk="TYPE" | tk="UNLOGGED" | tk="UNQIESCE" | tk="UNSIGNED" | tk="UPDATE" | tk="UPSERT" | tk="UR" | tk="USER" | tk="VALIDATE" | tk="VERBOSE" | tk="VIEW" | tk="VOLATILE" | tk="WAIT" | tk="WITHIN" | tk="WITHOUT" | tk="WITHOUT_ARRAY_WRAPPER" | tk="WORK" | tk="XML" | tk="XMLAGG" | tk="XMLDATA" | tk="XMLSCHEMA" | tk="XMLTEXT" | tk="XSINIL" | tk="YAML" | tk="YES" | tk="ZONE" ) + | tk="ACTION" | tk="ACTIVE" | tk="ADD" | tk="ADVANCE" | tk="ADVISE" | tk="AGAINST" | tk="ALGORITHM" | tk="ALTER" | tk="ANALYZE" | tk="APPLY" | tk="APPROXIMATE" | tk="ARCHIVE" | tk="ARRAY" | tk="ASC" | tk="AT" | tk="AUTHORIZATION" | tk="AUTO" | tk="AUTO_INCREMENT" | tk="BASE64" | tk="BEGIN" | tk="BERNOULLI" | tk="BINARY" | tk="BIT" | tk="BLOCK" | tk="BROWSE" | tk="BUFFERS" | tk="BY" | tk="BYTE" | tk="BYTES" | tk="CACHE" | tk="CALL" | tk="CASCADE" | tk="CASE" | tk="CAST" | tk="CHANGE" | tk="CHANGES" | tk="CHAR" | tk="CHARACTER" | tk="CHECKPOINT" | tk="CLOSE" | tk="COLLATE" | tk="COLUMN" | tk="COLUMNS" | tk="COMMENT" | tk="COMMIT" | tk="CONCURRENTLY" | tk="CONFLICT" | tk="CONSTRAINTS" | tk="CONVERT" | tk="COSTS" | tk="COUNT" | tk="CS" | tk="CYCLE" | tk="DATA" | tk="DATABASE" | tk="DATETIME" | tk="DBA_RECYCLEBIN" | tk="DDL" | tk="DECLARE" | tk="DEFERRABLE" | tk="DELAYED" | tk="DELETE" | tk="DESC" | tk="DESCRIBE" | tk="DISABLE" | tk="DISCONNECT" | tk="DIV" | tk="DML" | tk="DO" | tk="DOMAIN" | tk="DROP" | tk="DUMP" | tk="DUPLICATE" | tk="ELEMENTS" | tk="EMIT" | tk="ENABLE" | tk="ENCRYPTION" | tk="END" | tk="ENGINE" | tk="ERROR" | tk="ESCAPE" | tk="EXCLUDE" | tk="EXEC" | tk="EXECUTE" | tk="EXPLAIN" | tk="EXPLICIT" | tk="EXTENDED" | tk="EXTRACT" | tk="FILTER" | tk="FIRST" | tk="FLUSH" | tk="FN" | tk="FOLLOWING" | tk="FORMAT" | tk="FULLTEXT" | tk="FUNCTION" | tk="GRANT" | tk="GROUP_CONCAT" | tk="GUARD" | tk="HASH" | tk="HIGH_PRIORITY" | tk="HISTORY" | tk="HOPPING" | tk="INCLUDE" | tk="INCLUDE_NULL_VALUES" | tk="INCREMENT" | tk="INDEX" | tk="INSERT" | tk="INTERLEAVE" | tk="INTERPRET" | tk="INVALIDATE" | tk="ISNULL" | tk="JSON" | tk="JSON_ARRAY" | tk="JSON_ARRAYAGG" | tk="JSON_OBJECT" | tk="JSON_OBJECTAGG" | tk="KEEP" | tk="KEY" | tk="KEYS" | tk="LAST" | tk="LEADING" | tk="LESS" | tk="LINK" | tk="LOCAL" | tk="LOCK" | tk="LOCKED" | tk="LOG" | tk="LONGTEXT" | tk="LOOP" | tk="LOW_PRIORITY" | tk="MATCH" | tk="MATCHED" | tk="MATCH_ALL" | tk="MATCH_ANY" | tk="MATCH_PHRASE" | tk="MATCH_PHRASE_PREFIX" | tk="MATCH_REGEXP" | tk="MATERIALIZED" | tk="MAX" | tk="MAXVALUE" | tk="MEDIUMTEXT" | tk="MEMBER" | tk="MERGE" | tk="MIN" | tk="MINVALUE" | tk="MODIFY" | tk="MOVEMENT" | tk="NEXT" | tk="NO" | tk="NOCACHE" | tk="NOKEEP" | tk="NOLOCK" | tk="NOMAXVALUE" | tk="NOMINVALUE" | tk="NOORDER" | tk="NOTHING" | tk="NOTNULL" | tk="NOVALIDATE" | tk="NOWAIT" | tk="NULLS" | tk="OF" | tk="OFF" | tk="OPEN" | tk="OVER" | tk="OVERFLOW" | tk="OVERLAPS" | tk="OVERWRITE" | tk="PARALLEL" | tk="PARENT" | tk="PARTITION" | tk="PATH" | tk="PERCENT" | tk="PLACING" | tk="PLAN" | tk="PRECEDING" | tk="PRIMARY" | tk="PURGE" | tk="QUERY" | tk="QUICK" | tk="QUIESCE" | tk="RANGE" | tk="RAW" | tk="READ" | tk="RECURSIVE" | tk="RECYCLEBIN" | tk="REFERENCES" | tk="REFRESH" | tk="REGEXP" | tk="REGEXP_LIKE" | tk="REGISTER" | tk="REMOTE" | tk="RENAME" | tk="REPEATABLE" | tk="REPLACE" | tk="RESET" | tk="RESPECT" | tk="RESTART" | tk="RESTRICT" | tk="RESTRICTED" | tk="RESUMABLE" | tk="RESUME" | tk="RETURN" | tk="RLIKE" | tk="ROLLBACK" | tk="ROLLUP" | tk="ROOT" | tk="ROW" | tk="ROWS" | tk="RR" | tk="RS" | tk="SAFE_CAST" | tk="SAVEPOINT" | tk="SCHEMA" | tk="SECURE" | tk="SEED" | tk="SEPARATOR" | tk="SEQUENCE" | tk="SESSION" | tk="SETS" | tk="SHARE" | tk="SHOW" | tk="SHUTDOWN" | tk="SIBLINGS" | tk="SIGNED" | tk="SIMILAR" | tk="SIZE" | tk="SKIP" | tk="STORED" | tk="STRING" | tk="STRUCT" | tk="SUMMARIZE" | tk="SUSPEND" | tk="SWITCH" | tk="SYNONYM" | tk="SYSTEM" | tk="TABLE" | tk="TABLESPACE" | tk="TEMP" | tk="TEMPORARY" | tk="TEXT" | tk="THAN" | tk="THEN" | tk="TIMEOUT" | tk="TIMESTAMPTZ" | tk="TIMEZONE" | tk="TINYTEXT" | tk="TO" | tk="TRIGGER" | tk="TRUNCATE" | tk="TRY_CAST" | tk="TUMBLING" | tk="TYPE" | tk="UNLOGGED" | tk="UNQIESCE" | tk="UNSIGNED" | tk="UPDATE" | tk="UPSERT" | tk="UR" | tk="USER" | tk="VALIDATE" | tk="VERBOSE" | tk="VIEW" | tk="VOLATILE" | tk="WAIT" | tk="WITHIN" | tk="WITHOUT" | tk="WITHOUT_ARRAY_WRAPPER" | tk="WORK" | tk="XML" | tk="XMLAGG" | tk="XMLDATA" | tk="XMLSCHEMA" | tk="XMLTEXT" | tk="XSINIL" | tk="YAML" | tk="YES" | tk="ZONE" ) { return tk.image; } } diff --git a/src/test/java/net/sf/jsqlparser/statement/insert/InsertTest.java b/src/test/java/net/sf/jsqlparser/statement/insert/InsertTest.java index 13aae8862..97093502f 100644 --- a/src/test/java/net/sf/jsqlparser/statement/insert/InsertTest.java +++ b/src/test/java/net/sf/jsqlparser/statement/insert/InsertTest.java @@ -852,7 +852,7 @@ void testInsertOverwrite() throws JSQLParserException { assertNull(insert.getPartitions().get(0).getValue()); assertTrue(insert.isOverwrite()); - sqlStr = "INSERT OVERWRITE TABLE t PARTITION (pt1 = 'pt1', pt2 = 'pt2') SELECT * FROM a"; + sqlStr = "INSERT OVERWRITE\nTABLE t PARTITION (pt1 = 'pt1', pt2 = 'pt2') SELECT * FROM a"; insert = (Insert) assertSqlCanBeParsedAndDeparsed(sqlStr); assertEquals("t", insert.getTable().getName()); assertEquals(2, insert.getPartitions().size()); @@ -860,7 +860,7 @@ void testInsertOverwrite() throws JSQLParserException { assertEquals("'pt2'", insert.getPartitions().get(1).getValue().toString()); assertTrue(insert.isOverwrite()); - sqlStr = "INSERT INTO TABLE t PARTITION (pt1 = 'pt1', pt2 = 'pt2') SELECT * FROM a"; + sqlStr = "INSERT INTO\tTABLE t PARTITION (pt1 = 'pt1', pt2 = 'pt2') SELECT * FROM a"; insert = (Insert) assertSqlCanBeParsedAndDeparsed(sqlStr); assertEquals("t", insert.getTable().getName()); assertEquals(2, insert.getPartitions().size()); From 1f43345e49a1acdff0337ddb46dcebe24a43366b Mon Sep 17 00:00:00 2001 From: wetao Date: Fri, 3 Jan 2025 09:42:07 +0800 Subject: [PATCH 3/4] #2119 add reserved keyword --- src/main/java/net/sf/jsqlparser/parser/ParserKeywordsUtils.java | 1 + 1 file changed, 1 insertion(+) diff --git a/src/main/java/net/sf/jsqlparser/parser/ParserKeywordsUtils.java b/src/main/java/net/sf/jsqlparser/parser/ParserKeywordsUtils.java index 2ac33fbd3..f9e8767c1 100644 --- a/src/main/java/net/sf/jsqlparser/parser/ParserKeywordsUtils.java +++ b/src/main/java/net/sf/jsqlparser/parser/ParserKeywordsUtils.java @@ -114,6 +114,7 @@ public class ParserKeywordsUtils { {"OUTER", RESTRICTED_JSQLPARSER}, {"OUTPUT", RESTRICTED_JSQLPARSER}, {"OPTIMIZE ", RESTRICTED_JSQLPARSER}, + {"OVERWRITE ", RESTRICTED_JSQLPARSER}, {"PIVOT", RESTRICTED_JSQLPARSER}, {"PLUS", RESTRICTED_JSQLPARSER}, {"PREFERRING", RESTRICTED_JSQLPARSER}, From 2364b2a695bdc99902459b19a8fd431021f472de Mon Sep 17 00:00:00 2001 From: wetao Date: Mon, 6 Jan 2025 09:24:05 +0800 Subject: [PATCH 4/4] run spotlessApply --- src/main/java/net/sf/jsqlparser/schema/Partition.java | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/src/main/java/net/sf/jsqlparser/schema/Partition.java b/src/main/java/net/sf/jsqlparser/schema/Partition.java index 28b0cec45..2666a6e81 100644 --- a/src/main/java/net/sf/jsqlparser/schema/Partition.java +++ b/src/main/java/net/sf/jsqlparser/schema/Partition.java @@ -27,13 +27,13 @@ public Partition(Column column, Expression value) { this.value = value; } - public static StringBuilder appendPartitionsTo(StringBuilder builder, Collection partitions) { + public static void appendPartitionsTo(StringBuilder builder, + Collection partitions) { int j = 0; for (Partition partition : partitions) { partition.appendTo(builder, j); j++; } - return builder; } public Column getColumn() { @@ -54,7 +54,7 @@ public void setValue(Expression value) { @SuppressWarnings({"PMD.CyclomaticComplexity", "PMD.NPath"}) - StringBuilder appendTo(StringBuilder builder, int j) { + void appendTo(StringBuilder builder, int j) { if (j > 0) { builder.append(", "); } @@ -62,6 +62,5 @@ StringBuilder appendTo(StringBuilder builder, int j) { if (value != null) { builder.append(" = ").append(value); } - return builder; } }