Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues #158

Merged
merged 7 commits into from
Sep 8, 2016
Merged

Fix issues #158

merged 7 commits into from
Sep 8, 2016

Conversation

ilyankou
Copy link
Contributor

@ilyankou ilyankou commented Sep 8, 2016

Fix issues #154 #155 #156 #157

@JackDougherty JackDougherty merged commit 3cc4c9f into JackDougherty:master Sep 8, 2016
@corrigancd
Copy link

corrigancd commented Aug 4, 2019

@ilyankou, by any chance have you a way to add subtitles to layercontrol. Layer control groups plug in has a shortcoming that means my application of that plug in won't work (ismyrnow/leaflet-groupedlayercontrol#57 (comment)).

Any thoughts would be much appreciated!
Thanks.

@ilyankou
Copy link
Contributor Author

ilyankou commented Aug 4, 2019

@corrigancd Do you have a repo I can use as an example?

@corrigancd
Copy link

@ilyankou, it's line 227 and 233 in the file below. Im wondering how to add a subtitle to go before any poilayer is added? The addpoilayer method is called from viscontroller.js.

https://github.com/nreese/enhanced_tilemap/blob/master/public/vislib/_map.js

@ilyankou
Copy link
Contributor Author

ilyankou commented Aug 4, 2019

@corrigancd I would use jQuery to

  1. Wait until a layer is either added or removed to the map, then:
    1. Iterate through children of layer-control div
    2. Insert subtitle before the relevant child

This is definitely not elegant but would work. Another approach would be to go to Leaflet source code and modify add/remove layer functions to also add the subtitle along with the checkbox + label.

@corrigancd
Copy link

@ilyankou,thanks for the tips. I may end up adding layer controlgroup min file to my repo and making the 1 line fix there.

Thanks for the super fast responses though 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants