eyden-tracer-01 (makeup) #7
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ereator
reviewed
Dec 25, 2020
| @@ -18,7 +18,8 @@ class IPrim | |||
| * @brief Constructor | |||
| */ | |||
| IPrim(void) = default; | |||
| IPrim(const IPrim&) = delete; | |||
| // IPrim(const IPrim&) = delete; | |||
| IPrim(const IPrim&) = default; | |||
There was a problem hiding this comment.
You should not modify this file...
There was a problem hiding this comment.
Yes, professor, but it was giving me an error that function I was referencing does not exist.
| @@ -31,7 +31,28 @@ class CPrimTriangle : public IPrim | |||
| virtual bool intersect(Ray& ray) const override | |||
| { | |||
| // --- PUT YOUR CODE HERE --- | |||
| return false; | |||
| Vec3f n_ab = (m_b - ray.org).cross(m_a - ray.org); | |||
| // --- IMPLEMENT class CPrimDisc --- |
There was a problem hiding this comment.
I just corrected the typo.
There was a problem hiding this comment.
I meant the whole implementation for disc primitive
| @@ -3,5 +3,37 @@ | |||
| #include "ICamera.h" | |||
| #include "ray.h" | |||
|
|
|||
| // --- IMPLENET class CCameraEnvironmental --- | |||
| // --- IMPLEMENT class CCameraEnvironmental --- | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My environmental camera was not implemented correctly, but I did my best.