Call jags with full paths to files to avoid changing working directory #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avoid changing working directory
Add full paths to generated command files
needed to work in Windows
|
@hellemo, thanks for maintaining this package. I looked through the PR and it looks good as far as I can tell. I tried to run the code locally, but I could not find where Jags is installed on my system. I have no idea how I set it up in the past. If you have an idea where the default installation location is on Linux, or how to point it to the version used by rjags, I can take a deeper look. |
|
Thanks, not sure about rjags, I installed jags using the package manager with openSUSE-Tumbleweed and it is located in |
|
No such luck. It was installed somewhere in the abyss evidently. I think the changes look good and the tests look good. I say thumbs up. |
itsdfish
approved these changes
Dec 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I worked on this earlier this year, then forgot about it.
Jags.jl was changing pwd and in some cases did not change back to the original. I first fixed this issue, but then figured it would be better to call jags with full paths instead. What do you think?