Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why aren't proposed pull requests merged? #397

Closed
gnardini opened this issue Oct 19, 2015 · 2 comments
Closed

Why aren't proposed pull requests merged? #397

gnardini opened this issue Oct 19, 2015 · 2 comments

Comments

@gnardini
Copy link

Hi! Firstly, thank you very much for this library, I've found it incredibly useful and has helped me remove lots of boilerplate code on my apps.

That's exactly why I'm surprised it doesn't have more stuff. I just read some of the PRs and there are some very useful annotations there, such as #245 #229 #231 #201

They all look like they have useful aplications. In fact, I'm using two of them on an app I'm working with at the moment, but I'd be really nice if they already were integrated with the library, is there any reason they haven't been already? (some of them have been there for quite some time) I understand if you just want to keep this library as small as possible, but then maybe make a butterknife 2.0 or something with the extra stuff? Or is there another reason? Idk, just throwing ideas here :P

Anyways, just wondering, this still looks great, and thanks so much for all of your contributions to the Android community!

@gnardini gnardini changed the title Why are there so few annotations? Why aren't proposed pull requests merged? Oct 19, 2015
@gnardini gnardini closed this as completed Dec 3, 2015
@ViliusKraujutis
Copy link

@gnardini why did you close this issue without any update? Still wondering why #231 was not merged.

@JakeWharton
Copy link
Owner

JakeWharton commented Dec 6, 2016 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants