Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Injecting server urls for test purposes #6

Open
rorymckinley opened this issue Oct 29, 2022 · 0 comments
Open

Injecting server urls for test purposes #6

rorymckinley opened this issue Oct 29, 2022 · 0 comments

Comments

@rorymckinley
Copy link

Hello!

Firstly, thank you for building and maintaining this crate, it is much appreciated!

I would like to use the crate in a trivial little CLI - I am just trying to figure out how to structure my tests so that I don't end up spamming data.iana.org every time I run the tests. Would you be open to me submitting a change as follows?

  • Adding an host_url: String to the Client struct.
  • Adding a method to overwrite the host_url value
  • Changing the fetch_bootstrap_* methods to build URLs using self.host_url

The above would allow me to point the Client at mockito or something like mountebank.

I am a Rust noob but happy to submit the change if you are happy with the change. Alternatively, if you have an alternative implementation in mind, I would be happy to go that way as well.

Or, of course, if there is some way to already do the above (and I have just not looked properly) - that would be even better! 😄

Thanks for your time!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant