Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use 17 digits of precision with Double.ToString #2823

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Use 17 digits of precision with Double.ToString #2823

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f067837
Use 17 digits of precision with Double.ToString
oleks Feb 22, 2023
0796691
Make sure to use same type for AreEqual arguments
oleks Feb 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion Src/Newtonsoft.Json.Tests/JsonConvertTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1589,6 +1589,14 @@ public void CustomDoubleRounding()
Assert.AreEqual("{\"Positions\":[57.72,60.44,63.44,66.81,70.45],\"Loads\":[23284.0,23225.0,23062.0,22846.0,22594.0],\"Gain\":12345.679}", json);
}

[Test]
public void DoubleRoundTrip()
{
double x = 0.1 + 0.2;
double y = JsonConvert.DeserializeObject<double>(JsonConvert.SerializeObject(x));
Assert.AreEqual(x, y);
}

public class Measurements
{
[JsonProperty(ItemConverterType = typeof(RoundingJsonConverter))]
Expand Down Expand Up @@ -1830,4 +1838,4 @@ private int _expiration
public DateTime Expiration { get; set; }
}
}
}
}
2 changes: 1 addition & 1 deletion Src/Newtonsoft.Json/JsonConvert.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -292,7 +292,7 @@ private static string EnsureFloatFormat(double value, string text, FloatFormatHa
/// <returns>A JSON string representation of the <see cref="Double"/>.</returns>
public static string ToString(double value)
{
return EnsureDecimalPlace(value, value.ToString("R", CultureInfo.InvariantCulture));
return EnsureDecimalPlace(value, value.ToString("G17", CultureInfo.InvariantCulture));
}

internal static string ToString(double value, FloatFormatHandling floatFormatHandling, char quoteChar, bool nullable)
Expand Down