Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get update_tags to use jrc_author? #126

Closed
virginiascarlett opened this issue Nov 21, 2024 · 3 comments
Closed

Get update_tags to use jrc_author? #126

virginiascarlett opened this issue Nov 21, 2024 · 3 comments
Assignees

Comments

@virginiascarlett
Copy link
Collaborator

10.1016/j.isci.2024.111336

John Koberstein is in jrc_author, but update_tags.py recognizes no Janelia authors, and therefore suggests no tags.

@robsv
Copy link
Contributor

robsv commented Nov 21, 2024

The issue was that the author's given name ("John N.") wasn't in the database - only "John".
I fixed it by updating the orcid collection, but the proper fix will be one of two things:

  1. When adding a Janelia author to a paper, ensure that the author's given/family name is in the orcid collection
  2. Somehow override get_author_details to recognize an author without a name or ORCID match (as was the case here) to include entries in jrc_author. This will be ugly, with multiple finds in the orcis collection for a single author.

@virginiascarlett
Copy link
Collaborator Author

John Koberstein's name permutations were not added because I was simply neglecting to add name permutations to orcid records in cases where the author doesn't have an ORCID. Now the script does so, assuming the match was approved by the user.

@virginiascarlett
Copy link
Collaborator Author

fixed with 7c7ec5e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants