Not able to read/drop the property from the vertex

[pinal-shah]

Hello all,

Issue: I am not able to read or drop the property in vertex.

Reason: There is one property of datatype BigInteger, which is causing exception while reading the value.
The value entered for that property was integer value, which janusgraph is not able to parse it.

Janusgraph version: v0.6.1
Env: hbasev2.4.6, solr v8.4.1

Config:

janusConfig.setProperty("attributes.custom.attribute3.attribute-class", BigInteger.class.getName());
janusConfig.setProperty("attributes.custom.attribute3.serializer-class", BigIntegerSerializer.class.getName());

Error: below is the exception while accessing the vertex

java.lang.ArrayIndexOutOfBoundsException: Required size [1] exceeds actual remaining size [0] at org.janusgraph.diskstorage.util.StaticArrayBuffer.require(StaticArrayBuffer.java:94) at org.janusgraph.diskstorage.util.StaticArrayBuffer.getByte(StaticArrayBuffer.java:170) at org.janusgraph.diskstorage.util.StaticArrayBuffer.getBytes(StaticArrayBuffer.java:253) at org.janusgraph.diskstorage.util.ReadArrayBuffer.getBytes(ReadArrayBuffer.java:120) at org.janusgraph.graphdb.database.serialize.attribute.ByteArraySerializer.read(ByteArraySerializer.java:46) at org.apache.atlas.repository.graphdb.janus.serializer.BigIntegerSerializer.read(BigIntegerSerializer.java:36) at org.apache.atlas.repository.graphdb.janus.serializer.BigIntegerSerializer.read(BigIntegerSerializer.java:30) at org.janusgraph.graphdb.database.serialize.StandardSerializer.readObjectNotNullInternal(StandardSerializer.java:268) at org.janusgraph.graphdb.database.serialize.StandardSerializer.readObjectInternal(StandardSerializer.java:258) at org.janusgraph.graphdb.database.serialize.StandardSerializer.readObject(StandardSerializer.java:238) at org.janusgraph.graphdb.database.EdgeSerializer.readPropertyValue(EdgeSerializer.java:208) at org.janusgraph.graphdb.database.EdgeSerializer.readPropertyValue(EdgeSerializer.java:198) at org.janusgraph.graphdb.database.EdgeSerializer.parseRelation(EdgeSerializer.java:128) at org.janusgraph.graphdb.database.EdgeSerializer.readRelation(EdgeSerializer.java:73) at org.janusgraph.graphdb.transaction.RelationConstructor.readRelation(RelationConstructor.java:70) at org.janusgraph.graphdb.transaction.RelationConstructor$1.next(RelationConstructor.java:57) at org.janusgraph.graphdb.transaction.RelationConstructor$1.next(RelationConstructor.java:45) at org.apache.tinkerpop.gremlin.process.traversal.step.map.PropertyMapStep.map(PropertyMapStep.java:100) at org.apache.tinkerpop.gremlin.process.traversal.step.map.PropertyMapStep.map(PropertyMapStep.java:52) at org.apache.tinkerpop.gremlin.process.traversal.step.map.MapStep.processNextStart(MapStep.java:37) at org.apache.tinkerpop.gremlin.process.traversal.step.util.AbstractStep.hasNext(AbstractStep.java:143) at org.apache.tinkerpop.gremlin.process.traversal.util.DefaultTraversal.hasNext(DefaultTraversal.java:197) at org.apache.tinkerpop.gremlin.console.Console$_closure3.doCall(Console.groovy:255) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:498) at org.codehaus.groovy.reflection.CachedMethod.invoke(CachedMethod.java:101) at groovy.lang.MetaMethod.doMethodInvoke(MetaMethod.java:323) at org.codehaus.groovy.runtime.metaclass.ClosureMetaClass.invokeMethod(ClosureMetaClass.java:263) at groovy.lang.MetaClassImpl.invokeMethod(MetaClassImpl.java:1041) at org.codehaus.groovy.runtime.callsite.PogoMetaClassSite.call(PogoMetaClassSite.java:37) at org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:127) at org.codehaus.groovy.tools.shell.Groovysh.setLastResult(Groovysh.groovy:463) at sun.reflect.GeneratedMethodAccessor28.invoke(Unknown Source) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)

Tried below through gremlin

gremlin> bm22 = mgmt.getPropertyKey('bm22.datasetbigint').dataType()
==>class java.math.BigInteger

gremlin> g.V(8888324320).values('bm22.datasetbigint')
Required size [1] exceeds actual remaining size [0]
Type ':help' or ':h' for help.
Display stack trace? [yN]N

gremlin> g.V(8888324320).property(''bm22.datasetbigint',8768768767687)
Required size [1] exceeds actual remaining size [0]
Type ':help' or ':h' for help.
Display stack trace? [yN]N

gremlin> g.V(8888324320).valueMap();
Required size [1] exceeds actual remaining size [0]
Type ':help' or ':h' for help.
Display stack trace? [yN]N
gremlin>

Any ideas how can I read/fix this vertex?

There is another discussion similar #3336

[hadoopmarc]

To be sure, did you follow the instructions in:
https://docs.janusgraph.org/advanced-topics/serializer/

In particular, does your BigIntegerSerializer class implement the AttributeSerializer interface?
https://javadoc.io/static/org.janusgraph/janusgraph-core/1.0.0-20230327-054843.e0355d9/org/janusgraph/core/attribute/AttributeSerializer.html

[hadoopmarc]

O, I see from the call stack that it is in the Atlas repo and that the answers to my questions are yes and yes. So, please wait :-)

It seems best to first include your BigIntegerSerializer implementation in a copy of https://github.com/JanusGraph/janusgraph/blob/v0.6.3/janusgraph-test/src/test/java/org/janusgraph/graphdb/serializer/SerializerTest.java . That way, it is easier to check whether the problem is in the BigIntegerSerializer or not.

[pinal-shah]

Thanks @hadoopmarc for looking into this and for the quick response, I will verify BigIntegerSerializer class with this test.
I am sure that the value written to the property 'bm22.datasetbigint' is integer value.
Is there any way to read the vertex or any hackish way to drop the property or update the property value?
Below is my Class, While reading i also tried to read with IntegerSerializer, but it is giving incorrect values.

public class BigIntegerSerializer implements AttributeSerializer<BigInteger> {

    private final ByteArraySerializer delegate = new ByteArraySerializer();

    @Override
    public BigInteger read(ScanBuffer buffer) {
        byte[] value = delegate.read(buffer);
        return new BigInteger(value);
    }

    @Override
    public void write(WriteBuffer buffer, BigInteger attribute) {
        byte[] value = attribute.toByteArray();
        delegate.write(buffer, value);
    }

}

[hadoopmarc]

Since the meat of the BigIntegerSerializer is in the ByteArraySerializer it might also be interesting to have a ByteArray property and write/read the BigInteger values to it as ByteArrays via the gremlin API's.
Hackish ways: janusgraph includes functions to decode the HBase row and cell values, but I am afraid that is a rabbit hole. I think it will be easier to:

• copy the ByteArraySerializer to your own name space and add some judicious log statements (e.g. the bytes from the ReadBuffer)
• have the BigIntegerSerializer depend on that copied ByteArraySerializer