-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make classes more expandable #24
Comments
Hi Telefonman Can you point out what specific thing you want to change and in which class specifically? At first it sounds interesting to allow users of this API to alter the behavior of the layout by extending its classes. However, I would rather first suggest what is the specific use case you want to cover so we try to include your needs in the core API. The reason for this is that allowing all classes to be extendable the right way is pretty hard and once allowed we can are tied to backwards compatibility. |
In fact. I will suggest to make all classes final while this is not considered production ready yet. This way we will be able to know faster what people are doing with the API that we are not covering by default. |
Hi David, sorry for my late reply. The backwards compatibility is an important point, but the extensibility as well. In my particular case, I wanted to maximize and restore a ResponsiveColumn at runtime. I think other developers have great ideas on how to use responsive-layout in their projects, but they are severely restricted by their private and final definitions - and in some cases, perhaps even so much that they prefer other solutions. |
Thank you @Telefonmann1024 & @hofmanndavid I appreciate the feedback and insight. What I would really like is for responsiveLayout to be used creatively and I want to make the ResponsiveLayout have a more robust API. So to see what features and methods need to be added to make it very flexible on its own I want to know more about this. I'm particularly curious about your 2nd approach. You remember the old rule. Then with (12,12,12,12) you set the rules for each display size to 12. |
Thank you again @Telefonmann1024 for the insight into its use. After talking with @hofmanndavid. We will be Adding the protected methods and clean up the public and private definitions and he will be handling this issue. |
That sounds good - more next year. |
Hi,
can you please define some (or most of) classes and properties as proteced?
In my case, I want to change the rules at runtime to realize a column maximize feature. But the current rules are not available to me (even in a derived class) and I have to save them twice.
Oliver
The text was updated successfully, but these errors were encountered: