Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ResponsiveColumn introduces an unnecessary div #43

Open
chvndb opened this issue Aug 14, 2017 · 2 comments
Open

ResponsiveColumn introduces an unnecessary div #43

chvndb opened this issue Aug 14, 2017 · 2 comments

Comments

@chvndb
Copy link

chvndb commented Aug 14, 2017

Is there a specific reason why ResponsiveColumn extends StyleableComponent and not CssLayout?

This introduces an unnecessary div, which makes css tweaking more difficult.

@JarekToro
Copy link
Owner

I can't remember the exact reason offhand but I attempted to use CSSLayout initially, However something didn't pan out with it, it may have been a Vaadin Quirk or how the CSS I was using needed to be structured.

@chvndb
Copy link
Author

chvndb commented Aug 26, 2017

I see, in that case it might be better to avoid the extra div and avoid any unexpected quirks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants