Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot change opened project when plugin enabled #8

Open
mrbodich opened this issue Oct 1, 2018 · 4 comments
Open

Cannot change opened project when plugin enabled #8

mrbodich opened this issue Oct 1, 2018 · 4 comments
Labels

Comments

@mrbodich
Copy link

mrbodich commented Oct 1, 2018

When brackets-to-photoshop is enabled I cannot change active project. Don't work changing project using button with dropdown list on the left section. Don't work even dragging folder to brackets icon (Mac). When disabling plugin everything works...

@JavierAroche
Copy link
Owner

Hey @mrbodich I’ll take a look when I get a chance. Something could have changed in Bracket’s API recently, and I haven’t updated this plugin in a while.

@mrbodich
Copy link
Author

mrbodich commented Jan 8, 2019

Hey @mrbodich I’ll take a look when I get a chance. Something could have changed in Bracket’s API recently, and I haven’t updated this plugin in a while.

Hey Javier! How are you? Did you have a chance to fix this trouble ;)

@JavierAroche
Copy link
Owner

@mrbodich Sorry for the delay on this. Unfortunately I can't update this repo or make new releases for the time being.

However, the issue is coming from an error on my code, and it's very easy to fix.

In this function located in the main file, you just need to always return a string. So something like this would work:

function _filerErrors( message ) {
  if ( message && typeof message == "string" && message.toString().indexOf( 'Br-Ps' ) !== -1 ) {
    return message;
  } else {
    return '';
  }
}

@mrbodich
Copy link
Author

mrbodich commented Jan 9, 2019

@mrbodich Sorry for the delay on this. Unfortunately I can't update this repo or make new releases for the time being.

However, the issue is coming from an error on my code, and it's very easy to fix.

In this function located in the main file, you just need to always return a string. So something like this would work:

function _filerErrors( message ) {
  if ( message && typeof message == "string" && message.toString().indexOf( 'Br-Ps' ) !== -1 ) {
    return message;
  } else {
    return '';
  }
}

Javier, THANK YOU! It works now!
Just add this 'else {return ''}' when you will have ability to. It may help somebody else))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants