Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Netherite Ingot Oredict issue. #24

Open
xskutsu opened this issue Jan 29, 2025 · 3 comments · May be fixed by #25
Open

Netherite Ingot Oredict issue. #24

xskutsu opened this issue Jan 29, 2025 · 3 comments · May be fixed by #25

Comments

@xskutsu
Copy link

xskutsu commented Jan 29, 2025

The netherite ingot from this mod is still in the ore dict with futuremc installed. This causes the ingot to still show in recipes as an erroring item in recipes, and crafttweaker just shows it as .

Image

Ore entries for <ore:ingotNetherite> :
-<futuremc:netherite_ingot>
-<null>

Seems to only be an issue with ingots btw.

@xskutsu
Copy link
Author

xskutsu commented Jan 29, 2025

I also tried as a temporary solution to remove it manually, but because it's null I can't just do <ore:ingotNetherite>.remove(<null>);, nor can I do

for item in <ore:ingotNetherite> {
	<ore:ingotNetherite>.remove(item);
}
<ore:ingotNetherite>.add(<futuremc:netherite_ingot>);

@xskutsu
Copy link
Author

xskutsu commented Jan 30, 2025

Nevermind, it does afffect netherite blocks as well (and possibly blackstone i dont remember if futuremc adds blackstone)

Seems like the most straightforward fix is to just make sure futuremc compat is not enabled before adding the items to the oredict in the init mod recipes java file.

I'd just make a pull request but idk enough about java to know if it would be more than just importing the config and adding an if statement lol

@Jboymercs
Copy link
Owner

thank you for the PR, this project is not on my main priority but I'll get to accepting and fixing other bugs in the meantime. It'll probably be next week when I get a fix out. Again, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants