Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: bump semver to ^7.5.3 to fix audit issue #81

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+32 −6
Open

fix: bump semver to ^7.5.3 to fix audit issue #81

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 30 additions & 4 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "cls-hooked",
"version": "4.3.0",
"version": "4.3.1",
"description": "CLS using AsyncWrap instead of async-listener - Node >= 4.7.0",
"main": "index.js",
"files": [
Expand Down Expand Up @@ -41,7 +41,7 @@
"devDependencies": {
"chai": "^4.1.0",
"mocha": "^6.2.2",
"semver": "^6.3.0",
"semver": "^7.5.3",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Semver is used in index.js when the module is loaded. Should this be in dependencies instead of devDependencies?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The latest release to npm was v4.2.2 in 2017, with a non-dev dependency on semver ^5.4.1
After that, there were multiple changes that never got released, including this commit which moved
semver from dependencies to devDependencies. But that was never released and the latest code still uses semver during module load. Looks strange.

"sinon": "^7.5.0",
"sinon-chai": "^3.3.0",
"superagent": "^5.1.2",
Expand Down