Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Common CSV parser #24

Closed
1 task done
schr476 opened this issue Apr 11, 2024 · 4 comments · Fixed by #35
Closed
1 task done

Common CSV parser #24

schr476 opened this issue Apr 11, 2024 · 4 comments · Fixed by #35
Assignees
Labels
enhancement New feature or request Priority #1

Comments

@schr476
Copy link
Contributor

schr476 commented Apr 11, 2024

  • Migrate common CVS data parser to core framework.
@schr476 schr476 added enhancement New feature or request Priority #1 labels Apr 11, 2024
@schr476
Copy link
Contributor Author

schr476 commented Apr 18, 2024

@sgoldenCS what is the status on this?

@sgoldenCS
Copy link
Contributor

@schr476 At the meeting yesterday, we thought the parser was complete as it is already pulled into the main branch with unit tests. Additionally, other people in our group have started to use it and we have found that it generally implements all of the functionality we currently need. I was planning on writing some comments here and closing the issue...

@sgoldenCS
Copy link
Contributor

I've created a new module in a branch tied to this issue that implements a CSVParser. I've tested it using the pandas_parser unit test since the code is essentially identical. This should also resolve issue #33.

@sgoldenCS sgoldenCS linked a pull request Apr 22, 2024 that will close this issue
@Kishanrajput
Copy link

This includes closed issue: #33

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Priority #1
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants