Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

numpy_min_max_scaler Data Preps has an issue #62

Open
hasan2m opened this issue Dec 19, 2024 · 2 comments
Open

numpy_min_max_scaler Data Preps has an issue #62

hasan2m opened this issue Dec 19, 2024 · 2 comments
Assignees

Comments

@hasan2m
Copy link

hasan2m commented Dec 19, 2024

I was using the core to register my own work. I used the numpy_minmax_scaler.py from the core to scale my data. Feature range is provided in the config file as:

feature_range: (0,1)
data_store_loc: ""
store_loc: ""

Scikit-learn feature range should be a tuple. However, yaml file can't process tuple. Therefore, while I am running the code, it is considering as a string and I am getting the following error.

sklearn.utils._param_validation.InvalidParameterError: The 'feature_range' parameter of MinMaxScaler must be an instance of 'tuple'. Got '(0,1)' instead.

A lillte modification is needed in the numpy_minmax_scaler.py to convert it tuple before passing to scaler.

@dlersch
Copy link
Contributor

dlersch commented Dec 19, 2024

@hasan2m , thank you for pointing this out. Do you want me to fix it, or are you able to provide the fix by yourself?

@hasan2m
Copy link
Author

hasan2m commented Dec 19, 2024

I can do that. @dlersch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants