Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Taxor Profiling Module Not Utilizing Multiple Cores #15

Open
tthye1 opened this issue Feb 26, 2025 · 2 comments
Open

Taxor Profiling Module Not Utilizing Multiple Cores #15

tthye1 opened this issue Feb 26, 2025 · 2 comments

Comments

@tthye1
Copy link

tthye1 commented Feb 26, 2025

Dear Jens,

Thank you for this excellent tool. I noticed that when running the profile module, taxor only utilizes one core, even though 20 cores have been assigned. As a result, the process has been running now for two days. In contrast, the search module effectively uses multiple cores.

Best,

Thorsten

Applied code:

taxor profile
--threads 20
--search-file /data/out_META_00_MAG/C10342-TZ_NP.search.txt
--cami-report-file C10342-TZ_NP.report
--seq-abundance-file C10342-TZ_NP.abundance
--binning-file C10342-TZ_NP.binning
--sample-id C10342-TZ_NP

@JensUweUlrich
Copy link
Owner

Dear Thorsten,

thanks fo your interest in Taxor. I just recently did some bug fixes and performance improvements in Taxor, which are implemented and provided in the latest version 0.2.0. The version is actually not merged into the bioconda main branch, but I hope this will happen within the next days.
You are absolutely right that the profiling module is not multi-threaded. I tried to implement multi-threading for several code blocks, but without any performance improvements. Since the performance in the latest version is satisfying, I removed the thread option and thus offered a parameter to provide the number of EM steps.
Please do also not use the actual pebuilt GTDB index file, which will give you wrong results. I will also upload a fixed index file within the next days. I'll let you know when both the new index and the new bioconda version of taxor are ready to use.

@tthye1
Copy link
Author

tthye1 commented Feb 28, 2025 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants