Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speed up Pyworld #58

Open
tranctan opened this issue Nov 9, 2020 · 5 comments
Open

Speed up Pyworld #58

tranctan opened this issue Nov 9, 2020 · 5 comments

Comments

@tranctan
Copy link

tranctan commented Nov 9, 2020

Hi, may I ask if you any suggestions for speeding up PyWorld? I have been thinking about this but have not figured out which is a proper way.

Looking forward to your comments. :D

@JeremyCCHsu
Copy link
Owner

Good question, though I don't know what can be done from the wrapper side. Maybe it has to be done on the C code side (from the original repo)?

@tranctan
Copy link
Author

tranctan commented Nov 18, 2020

Hi, thanks for your ideas! Since there is another issue #55 mentioning about bringing the code to GPU with CuPy. I'm not experienced much with Python wrapping, so do you think this is possible ?

If not then the only way has to be on the C code side.

@JeremyCCHsu
Copy link
Owner

I was expecting an answer from the community, too. 😅 I don't have experience on CuPy. Not sure how that works, but I thought it's the C++ code in WORLD that does the heavy lifting in PyWORLD. Anyway, please let us know if you try anything out.

@tranctan
Copy link
Author

Sure, I think I will leave this issue open if there is anyone out there interested !

@oxygen-dioxide
Copy link

oxygen-dioxide commented Aug 12, 2021

Good question, though I don't know what can be done from the wrapper side. Maybe it has to be done on the C code side (from the original repo)?

from the wrapper side, please release the GIL each time when running time-consuming c functions, so users can run pyworld multithreaded

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants