-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose Iterator
types
#56
Comments
Yeah, the |
I also thought about supporting other integer types. Any reason you dropped that idea? |
Mostly ran out of motivation. And back when I started writing this project const compilation weren't ready yet. Changing the constant used during hashing should be enough to support different int types. |
Not sure about the growth algo, but support for different integer types would be very nice in my opinion. And I'm not convinced yet that this would increase complexity significantly. I think it should even be possible without breaking changes thanks to default type parameters, e.g. |
The growth algorithm should be fine, it only changes the number of elements in the backing vector. You would need to be able to switch between |
The
Iterator
types ofintmap
are currently private, see the doc. Based on the source code I'm not sure if this was an intentional decision.As long as rust-lang/rust#63063 is not merged, it's important to expose these type so that they can be used inside of structs and enums.
I suggest:
Iterator
types by re-exporting them at top-levelK
from the currentIterator
types. It feels a little bit inconsistent becauseIntMap
don't have this type parameter either.The text was updated successfully, but these errors were encountered: