Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dart] Update the pub inspector to look up the directory structure to support the Dart Analysis workspaces feature #933

Closed
wants to merge 1 commit into from

Conversation

jwren
Copy link
Contributor

@jwren jwren commented Nov 23, 2024

@alexander-doroshko
Copy link
Member

@jwren Thanks for the PR. Is this document the single source of truth or there are other sources of information about how it works?

[WIP]

So should I apply it as is or wait for updates?

BTW, do you think it's important for the Dart plugin to look into the pubspec.yaml file contents and have different logic depending on the resolution and workspace tags presence?

Are there other features in the Dart plugin that should be aware of the workspaces feature?

For example, should we keep showing the bar with Pub Get/Pub Upgrade/Pub Outdated actions in the pubspec.yaml files with the resolution tag?

@jwren jwren changed the title [WIP] [Dart] Update the pub inspector to look up the directory structure to support the Dart Analysis workspaces feature [Dart] Update the pub inspector to look up the directory structure to support the Dart Analysis workspaces feature Nov 25, 2024
@jwren
Copy link
Contributor Author

jwren commented Nov 25, 2024

Thanks @alexander-doroshko.

@jwren Thanks for the PR. Is this document the single source of truth or there are other sources of information about how it works?

Yes, I believe so.

[WIP]

So should I apply it as is or wait for updates?

I added some comments, yes, land it and push it to older IDEA platform versions if possible. I am still able to push updated Flutter IJ versions to 2023.3, but 2024.1 and forward is sufficient.

BTW, do you think it's important for the Dart plugin to look into the pubspec.yaml file contents and have different logic depending on the resolution and workspace tags presence?

I think it is fine as-is, while we could possibly not go up a directory speeding up the check, I'd rather not be in parsing the yaml files, the fewer number of checks (existence of files) is deep enough in the weeds of what pub is doing.

Are there other features in the Dart plugin that should be aware of the workspaces feature?

For example, should we keep showing the bar with Pub Get/Pub Upgrade/Pub Outdated actions in the pubspec.yaml files with the resolution tag?

Possibly, something like this would be a reason to read and parse the yaml files.

I will take and action item to see if we are missing anything, need to add anything, etc. (But lets not wait on landing this in the mean-time.)

@alexander-doroshko
Copy link
Member

Merged, thanks

intellij-monorepo-bot pushed a commit that referenced this pull request Nov 28, 2024
…b Get has not been run'

close #933


(cherry picked from commit 42ed461a1682d59fe6642a672a466c1fd722bb28)

IJ-CR-150418

GitOrigin-RevId: 8fe072ed99b4f73c90f4c157a94c8794270ee0e8
intellij-monorepo-bot pushed a commit that referenced this pull request Nov 28, 2024
…b Get has not been run'

close #933


(cherry picked from commit 42ed461a1682d59fe6642a672a466c1fd722bb28)

IJ-CR-150418

GitOrigin-RevId: 4612fe9657deac0a9d36101b611d41818bf90e25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants