Build linux arm target on arm machine #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eymar
reviewed
Feb 20, 2025
| strategy: | ||
| matrix: | ||
| build_type: [ Debug, Release ] | ||
| fail-fast: false | ||
| steps: | ||
| - uses: actions/checkout@v2 | ||
| - uses: uraimo/run-on-arch-action@v2.8.1 | ||
| - uses: addnab/docker-run-action@v3 |
There was a problem hiding this comment.
I guess it's necessary because we want to get an older Ubuntu version?
There was a problem hiding this comment.
@eymar unfortunately yes - because we need to build in Ubuntu 20.04 - and the minimal arm machine in github runner is Ubuntu 22.04
eymar
approved these changes
Feb 20, 2025
igordmn
approved these changes
Feb 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses https://youtrack.jetbrains.com/issue/CMP-7630 - basically, the minimal Ubuntu should be 20.04 (this is our common agreement so far).
After rebasing to m132 it was not the case for linux arm distribution - because it was just failing (for a bunch of various reasons) on Ubuntu 20.04 we've just switched to 22.04.
Here's how this particular PR addresses this issue: We build on an arm machine however still in docker - Since minimal github configuration for arm is, again, 22.04. Apart from that there are no two different pre-publish steps - for main branch and for PR branches - the only difference was archiving and archiving is cheap (and we see if something is wrong with archiving earlier)