Hyperref issue in .sty file

[hanbingyan]

Perhaps it is not a good idea to set

\RequirePackage[colorlinks=false,allbordercolors={1 1 1}]{hyperref}

For example, consider the following two lines

The hat of a function f is almost missing. The correct result should be

Why? Because the WHITE border is overlapped with the hat! It's really hard to detect this bug and it costs me a whole afternoon and night...

I suggest

\RequirePackage[breaklinks=true, hidelinks]{hyperref}

[fabianp]

this change makes sense to me. What do you think @akucukelbir ?

[akucukelbir]

Hyperref issues cause 90% of typesetting problems at JMLR; the remainder are authors modifying margins.

I'll take a look. Appreciate the ping @hanbingyan @fabianp

[willleeney]

a simple fix for this is setting the line to \RequirePackage[colorlinks=false,pdfborder={0 0 0}]{hyperref}. the old version sets border of the hyperlinks to white in a weird way so you can still kinda see the edge of the linking box. this replacement fits this for me.

[fabianp]

any opinion on this @kevinsbello (our new production manager)?