Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update compat and remove redundant fixed #47

Merged
merged 10 commits into from
Oct 18, 2024
Merged

Update compat and remove redundant fixed #47

merged 10 commits into from
Oct 18, 2024

Conversation

JoeyT1994
Copy link
Owner

This PR updates the compat on ITensorNetworks and Graphs to more recent versions and removes functions in fixes.jl which were addressed by the PRs in ITensor/ITensorNetworks.jl#195 and ITensor/ITensorNetworks.jl#194

@JoeyT1994 JoeyT1994 requested a review from ryanlevy October 17, 2024 14:46
@ryanlevy
Copy link
Collaborator

Looks good besides formating, some requests/questions:

  • Can you bring the workflows up to the current version in here too? (see e.g. ITensors.jl, using actions/checkout@v4 )
  • Do we want to add the dependabot?
  • currently using fixes.jl fails for Julia 1.11.0 (they have an open bug about it), any chance we can get rid of it now or overload the add function differently?

@JoeyT1994
Copy link
Owner Author

Sure I just bought up the workflows to checkout@v4 and setup-julia@v2 . I also formatted.

Not sure what to do about fixes.jl not working with Julia 1.11.0, do you think they will resolve that issue soon? Quite useful to have a fixes.jl here so we can overload ITensorNetworks functionality with ease -- but I'm open to other suggestions.

Project.toml Outdated Show resolved Hide resolved
@ryanlevy
Copy link
Collaborator

Wow that new formatter really screwed up some things. I think I've sorted everything out including the fixes.jl, let me know if everything works on your end and then I'm good with merging

@JoeyT1994
Copy link
Owner Author

Thanks! Yeah no idea what that new formatter version is about. Looks good now though.

@JoeyT1994 JoeyT1994 merged commit 65329d8 into main Oct 18, 2024
3 checks passed
@JoeyT1994 JoeyT1994 deleted the update_fixes branch October 18, 2024 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants