Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken by Sketch 3.9 with "Set Page's Stylesheet" selection loop. #47

Open
nbiehl opened this issue Jul 20, 2016 · 13 comments
Open

Broken by Sketch 3.9 with "Set Page's Stylesheet" selection loop. #47

nbiehl opened this issue Jul 20, 2016 · 13 comments

Comments

@nbiehl
Copy link

nbiehl commented Jul 20, 2016

CSSketch no longer functions with the Sketch 3.9 update. Attempting to assign a stylesheet to a sketch doc results in a selection loop:

  1. Open a sketch doc. In this case the Keyboard.sketch example.
  2. Select "Plugins" > "CSSketch" > "Set Page's Style"
  3. Finder opens > Navigate to and select Keyboard.less stylesheet > Click "Choose"
  4. After clicking the "Choose" button, it becomes disabled.
  5. Reselect Keyboard.less > Click "Choose"
  6. GoTo # 4 and repeat infinitum.
@fadlee
Copy link

fadlee commented Jul 22, 2016

I had this problem too

@bichinl
Copy link

bichinl commented Jul 28, 2016

Hi, I have the same problem here. Sketch 3.9.1

@rezki-olx
Copy link

+1 same problem. Sketch 3.9.1

@JohnCoates , I would love to help, but don't know where to start. Seems like the plugin fails to get the stylesheet URL. Or am I digging at the wrong place? Really appreciate your help here

@fredDesign
Copy link

fredDesign commented Aug 10, 2016

Ok thats why nothing happens when i try to use this plugin 🎯

@aaadryyy
Copy link

aaadryyy commented Aug 10, 2016

Daaaaamn! To good to be true...

Do you think you can do something @JohnCoates ?

@rezki-olx Please do something !

@shendrick
Copy link

+1

1 similar comment
@Davst
Copy link

Davst commented Aug 24, 2016

+1

@kamil-borkowski
Copy link

+1 does not work in Sketch 3.9.1

@kristianmandrup
Copy link

Let's try to debug to see where the mismatch is... Don't just complain ;)

@hendrykj
Copy link

hendrykj commented Sep 8, 2016

+1 any updates on this?

@ghost
Copy link

ghost commented Sep 27, 2016

Having the same issue with Version 4.0.1.

Also console is showing this error, not sure if it is related:
image

Appreciate your help in solving this @JohnCoates

@eliteproxy7
Copy link

same here

@samueljoos
Copy link
Contributor

I'm trying to debug this issue. It seems like the context argument of
(void)selectStylesheetWithContext:(NSDictionary *)context
Is always an empty dictionary. The dictionary should contain a document and a command property to make the connection between the css and the sketch file.

The strange thing is that the context does has value in the CSSSketch.js file but it gets lost when its send to CSKMainController.selectStylesheetWithContext.

I'll try to fix the issue but I'm new with sketch plugin development so any hints or tips might come in handy.

JohnCoates added a commit that referenced this issue Nov 23, 2016
fix endless file selecting loop issue #47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests