Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hardcoded path to icons.svg #16

Open
martin-ro opened this issue Oct 13, 2019 · 3 comments
Open

Hardcoded path to icons.svg #16

martin-ro opened this issue Oct 13, 2019 · 3 comments
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@martin-ro
Copy link

Is there a better solution then to hard code the path to icons.svg? When deploying assets to for example S3 the icons can't be found.

Or maybe a setting to set a custom path.

@Johnathan Johnathan added bug Something isn't working help wanted Extra attention is needed labels Oct 15, 2019
@Johnathan
Copy link
Owner

Johnathan commented Oct 15, 2019

@martin-ro Thanks for the report. I'm not sure about this to be honest because the path to icons.svg comes from the trumbowyg package itself but it's definitely something that needs to be addressed.

@martin-ro
Copy link
Author

There is an option to change the path to the icons in trumbowyg. Not sure if that can be used to fix the issue.

@Johnathan
Copy link
Owner

And a prop on vue-trumbowyg which is used underneath so definitely seems possible. I'll try and get a look at it this week, if you need it sooner feel free to make a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants