From 5545b66c2556a4d57f50e13e9bffa60a087967cc Mon Sep 17 00:00:00 2001 From: checkraisefold Date: Sat, 26 Oct 2024 14:40:55 -0700 Subject: [PATCH] fix review --- src/DocumentationParser.cpp | 2 +- tests/main.cpp | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/src/DocumentationParser.cpp b/src/DocumentationParser.cpp index dc7c9c5e..f5e0fe83 100644 --- a/src/DocumentationParser.cpp +++ b/src/DocumentationParser.cpp @@ -459,7 +459,7 @@ std::optional WorkspaceFolder::getDocumentationForType(const Luau:: { return printMoonwaveDocumentation(getComments(ftv->definition->definitionModuleName.value(), ftv->definition->definitionLocation)); } - else if (auto ttv = Luau::get(followedTy); ttv) + else if (auto ttv = Luau::get(followedTy); ttv && !ttv->definitionModuleName.empty()) { return printMoonwaveDocumentation(getComments(ttv->definitionModuleName, ttv->definitionLocation)); } diff --git a/tests/main.cpp b/tests/main.cpp index 44686cf0..492bad14 100644 --- a/tests/main.cpp +++ b/tests/main.cpp @@ -1,3 +1,4 @@ +#include #define DOCTEST_CONFIG_NO_UNPREFIXED_OPTIONS #define DOCTEST_CONFIG_IMPLEMENT #include "doctest.h" @@ -15,7 +16,7 @@ int main(int argc, const char** argv) if (strcmp(argv[i], "--new-solver") == 0) { FFlag::LuauSolverV2.value = true; - DFInt::LuauTypeSolverRelease.value = 645; + DFInt::LuauTypeSolverRelease.value = std::numeric_limits::max(); break; } }