Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return stakes is failing for a motion #4158

Closed
rumzledz opened this issue Jan 22, 2025 · 4 comments · Fixed by #4180
Closed

Return stakes is failing for a motion #4158

rumzledz opened this issue Jan 22, 2025 · 4 comments · Fixed by #4180
Assignees
Labels
bug Something isn't working Priority: P0 (Critical)

Comments

@rumzledz
Copy link
Contributor

rumzledz commented Jan 22, 2025

Steps to reproduce

  1. Install the Reputation extension
  2. As leela, make an Simple Payment motion using the Reputation decision method
  3. Oppose and fully stake it
  4. Copy the transaction URL
  5. As amy, visit the URL
  6. As amy, support and fully stake it
  7. During the voting phase, as amy, Oppose and submit your vote
  8. As amy, change your vote, you should now be supporting it
  9. As leela, Approve and submit your vote
  10. Finalise the motion
  11. As leela, click the Return Stakes button
  12. Verify that this operation succeeds
  13. As amy, click the Return Stakes button

Expected behaviour

The Return stakes button should not be rendered anymore.

Actual behaviour

The Return stakes button is still there for Amy. Clicking the button does nothing on the UI and you get an error on the console:

Image
@rumzledz rumzledz added the bug Something isn't working label Jan 22, 2025
@jakubcolony
Copy link
Collaborator

@rumzledz Does the button work the first time you click it and the saga only fails on subsequent clicks?

@rumzledz
Copy link
Contributor Author

@rumzledz Does the button work the first time you click it and the saga only fails on subsequent clicks?

Hey @jakubcolony the button just does not work for Amy at all in the flow I've provided. For leela, the Return stakes button disappears and the widget is replaced by:

Image

Whereas wit amy, the widget is still at:

Image

@arrenv
Copy link
Member

arrenv commented Jan 22, 2025

Does it work from the "Stakes" tab in the Userhub?

@rumzledz rumzledz self-assigned this Jan 22, 2025
@rumzledz
Copy link
Contributor Author

rumzledz commented Jan 22, 2025

Does it work from the "Stakes" tab in the Userhub?

@arrenv it doesn't 😕

Latest findings @jakubcolony @arrenv: whoever opposed during the staking process is unable to claw back their stakes:

Image

@rumzledz rumzledz changed the title Return stakes is failing Return stakes is failing for an Agreement Jan 22, 2025
@rumzledz rumzledz changed the title Return stakes is failing for an Agreement Return stakes is failing for a motion Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Priority: P0 (Critical)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants