Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Race Condition #17

Open
ole-larsen opened this issue Oct 28, 2023 · 0 comments
Open

Race Condition #17

ole-larsen opened this issue Oct 28, 2023 · 0 comments

Comments

@ole-larsen
Copy link

ole-larsen commented Oct 28, 2023

found race condition in proxy.go
to fix add mutex to get/set

// bufferPool is a httputil.BufferPool backed by a bytebufferpool.ByteBuffer.
type bufferPool struct {
	mx sync.Mutex
	*bytebufferpool.ByteBuffer
}

func (b *bufferPool) Get() []byte {
	b.mx.Lock()
	defer b.mx.Unlock()
	return b.Bytes()
}

func (b *bufferPool) Put(payload []byte) {
	b.mx.Lock()
	defer b.mx.Unlock()
	b.Set(payload)
}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant