Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

logo.php (template features) : wrong height attribut value #348

Open
Savama51 opened this issue Sep 11, 2023 · 4 comments
Open

logo.php (template features) : wrong height attribut value #348

Savama51 opened this issue Sep 11, 2023 · 4 comments

Comments

@Savama51
Copy link

Steps to reproduce the issue

For px unit :
Add a png image in the param Basis > Logo > Logo.
Set the Logo Height to 60, px (unit)

Or for other units :
Set the Logo Height to 16, em (unit)

Expected result

In html code source for px unit :

<img class='logo-image '
srcset='https:/mywebsite.com/images/my_logo.png 1x'
src='https:/mywebsite.com/images/my_logo.png'
height="60"
alt='My Website !'

Or for other units :

<img class='logo-image '
srcset='https:/mywebsite.com/images/my_logo.png 1x'
src='https:/mywebsite.com/images/my_logo.png'
alt='My Website !'

Actual result

In html code source for px unit :

<img class='logo-image '
srcset='https:/mywebsite.com/images/my_logo.png 1x'
src='https:/mywebsite.com/images/my_logo.png'
height='60px'
alt='My Website !'

Or for other units :

<img class='logo-image '
srcset='https:/mywebsite.com/images/my_logo.png 1x'
src='https:/mywebsite.com/images/my_logo.png'
height='16em'
alt='My Website !'

System information (as much as possible)

Joomla! 4.3.4
Helis Ultimate 2.0.14

Additional comments

In the HTML doc, height value specifies the height of an image *in pixels".
So, the value of logo height should be displayed without "px", and only if px is the unit selected !

The attribut height sould be removed if other unit than px is selected ?

The height attribute is not présent for the mobile logo... should it be ?

@Savama51 Savama51 changed the title logo.php : wrong height attribut value logo.php (template features) : wrong height attribut value Sep 11, 2023
@mi-prakash
Copy link
Contributor

@Savama51 this issue has been fixed in the recent updates.. can u confirm ?

@Savama51
Copy link
Author

Savama51 commented Nov 1, 2023

@mi-prakash I've tested with latest 2.0.16, same issue.

@joomleb
Copy link

joomleb commented May 21, 2024

Hi guys,
@Savama51 Please, Can you confirm the bug with the last Joomla 4.4.4 + Helix Ultimate 2.1.1 ?

@Savama51
Copy link
Author

Hi guys, @Savama51 Please, Can you confirm the bug with the last Joomla 4.4.4 + Helix Ultimate 2.1.1 ?

Hello,
Unfortunately, problem remains with latest 2.1.1 version...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants