Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for --javascript-delay #10

Open
icnocop opened this issue Mar 31, 2020 · 2 comments
Open

Add support for --javascript-delay #10

icnocop opened this issue Mar 31, 2020 · 2 comments

Comments

@icnocop
Copy link

icnocop commented Mar 31, 2020

Hi.

Thank you for crPDF.

wkhtmltopdf supports the --javascript-delay command line option.

See https://wkhtmltopdf.org/usage/wkhtmltopdf.txt

If a javascript delay isn't supported in puppeteer, I'm thinking crPDF should just ignore the command line option.

Currently, crPDF outputs error: unknown option '--javascript-delay' and doesn't produce the expected output.

Thank you.

@JorgenEvens
Copy link
Owner

Hi @icnocop ,

Thanks for your interest in this project, I'll try to look into this and your other issues later today.

@icnocop
Copy link
Author

icnocop commented Apr 9, 2020

Hi @JorgenEvens.

I went ahead and implemented these feature requests in another project.

You may close the issues I created if you'd like.

Thank you for the inspiration! 🌟

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants