Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🧪 Testing: Rename "mutation" tests to "integration" #1505

Open
JoshuaKGoldberg opened this issue Apr 1, 2024 · 3 comments
Open

🧪 Testing: Rename "mutation" tests to "integration" #1505

JoshuaKGoldberg opened this issue Apr 1, 2024 · 3 comments
Labels
area: documentation Improvements or additions to docs 📝 area: testing Improving how the repository's tests are run and/or code is tested 🧪 status: accepting prs Please, send a pull request to resolve this! 🙏

Comments

@JoshuaKGoldberg
Copy link
Owner

Overview

I originally named "mutation" tests in this library and auto-mutate/automutate-tests as such because they were testing "mutators". The naming all made sense.

But, "mutation testing" is separately a thing! https://stryker-mutator.io. IMO it's confusing to use the phrase in a way different from the industry norm.

Proposal: let's switch the name for the concept in this repo to... say, integration tests? That's basically what they are, I think. WDYT @rubiesonthesky?

@JoshuaKGoldberg JoshuaKGoldberg added status: in discussion Not yet ready for implementation or a pull request area: documentation Improvements or additions to docs 📝 area: testing Improving how the repository's tests are run and/or code is tested 🧪 labels Apr 1, 2024
@rubiesonthesky
Copy link
Collaborator

rubiesonthesky commented Apr 1, 2024

I think integration tests make sense. I'm favor of that!

I also think that separate end to end tests would be great! But let's wait with that until monorepo support.

Edit: haha #1506 , you already made task about that :)

@JoshuaKGoldberg JoshuaKGoldberg changed the title 🧪 Testing: Find a new name for "mutation" tests 🧪 Testing: Rename "mutation" tests to "integration" Apr 1, 2024
@JoshuaKGoldberg JoshuaKGoldberg added status: accepting prs Please, send a pull request to resolve this! 🙏 and removed status: in discussion Not yet ready for implementation or a pull request labels Apr 1, 2024
@rubiesonthesky
Copy link
Collaborator

Would you think it would make sense to rename folder test to integrationTests? I would also move the testSetup.ts file there so they are all together.

@JoshuaKGoldberg
Copy link
Owner Author

Ehhh I'm not a fan of long folder names in the root. IME it gets annoying and inconvenient to work with. test is a pretty common standard - let's stick with it IMO.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: documentation Improvements or additions to docs 📝 area: testing Improving how the repository's tests are run and/or code is tested 🧪 status: accepting prs Please, send a pull request to resolve this! 🙏
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants