Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🚀 Feature: Allow specifying multiple possible types with || #109

Closed
3 tasks done
JoshuaKGoldberg opened this issue Dec 11, 2023 · 0 comments · Fixed by #634
Closed
3 tasks done

🚀 Feature: Allow specifying multiple possible types with || #109

JoshuaKGoldberg opened this issue Dec 11, 2023 · 0 comments · Fixed by #634
Labels
status: accepting prs Please, send a pull request to resolve this! 🙏 type: feature New enhancement or request 🚀
Milestone
Feature Parity: d...

Comments

@JoshuaKGoldberg
Copy link
Owner

Bug Report Checklist

  • I have tried restarting my IDE and the issue persists.
  • I have pulled the latest main branch of the repository.
  • I have searched for related issues and found none that matched my issue.

Overview

Splitting out from microsoft/DefinitelyTyped-tools#858 (comment): @definitelytyped/expect allows comments to specify multiple allowed type candidates with ||. https://github.com/microsoft/DefinitelyTyped-tools/blob/42484ff245f6f18018de729f12c9a28436daa08a/packages/eslint-plugin/src/rules/expect.ts#L466

That's useful in particular when testing across TS versions (#107). Let's bring the feature in here!

Additional Info

No response
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: accepting prs Please, send a pull request to resolve this! 🙏 type: feature New enhancement or request 🚀
Projects
None yet
Milestone
Feature Parity: dtslint
Development

Successfully merging a pull request may close this issue.

feat: support ||s and type normalization for comparisons JoshuaKGoldberg/eslint-plugin-expect-type
1 participant
@JoshuaKGoldberg