Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix initial condition from Dingemans experiment for BBM-BBM equations #91

Merged
merged 4 commits into from
Feb 24, 2024

Conversation

JoshuaLampert
Copy link
Owner

The results from the BBM-BBM equations for the experimental setup was missing a vertical translation of the water surface and the bathymetry. This is fixed here and the notation about the bathymetry $b$ and still water depth $D$ is used consistently.
We have $D = \eta_0 - b$ for the still water surface $\eta_0$. The still water surface can be arbitrary in the case of the Svärd-Kalisch equations, but needs to be 0 for the BBM-BBM equations (otherwise there would be an additional term in the equations).

use notation related to still water depth consistently
Copy link

codecov bot commented Feb 23, 2024

Codecov Report

Attention: Patch coverage is 96.55172% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 96.17%. Comparing base (f206ad8) to head (0fb139a).

Files Patch % Lines
src/equations/bbm_bbm_1d.jl 85.71% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #91      +/-   ##
==========================================
+ Coverage   96.15%   96.17%   +0.02%     
==========================================
  Files          17       17              
  Lines        1065     1073       +8     
==========================================
+ Hits         1024     1032       +8     
  Misses         41       41              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@ranocha ranocha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@JoshuaLampert JoshuaLampert merged commit e0d3a92 into main Feb 24, 2024
14 checks passed
@JoshuaLampert JoshuaLampert deleted the fix-bathymetry-definitions branch February 24, 2024 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants