Add support for formatting from the Deck UI #418
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samueldr
force-pushed
the
wip/automount-and-format
branch
from
f194032 to
e415612
Compare
samueldr
commented
Oct 6, 2024
samueldr
commented
Oct 6, 2024
samueldr
force-pushed
the
wip/automount-and-format
branch
2 times, most recently
from
758c4d1 to
b2cfb2d
Compare
The support scripts are intended to replace vendor scripts for the little details we can't do the same way. We're adding the pair of scripts required to format external devices. Note that the scripts end-up relying on the steamos-manager service, which in turn already knows how to launch the hw-support scripts. How convenient.
This is a bit of a misnomer. It also adds "better" formatting support.
samueldr
force-pushed
the
wip/automount-and-format
branch
from
b2cfb2d to
96ef195
Compare
samueldr
added
2. priority: 3. low
2. topic: system integration
|
(Drafted to make filtering PRs easier; there's the TODO things to... do...) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #413. Closes #321.
This change set implements the formatting script in a way that works under our FHS...
... by using the method Steam would end-up using in the future? (Assuming it'll rely on
steamos-manager.With this one weird trick the script is doing, it looks like the script is actually running, and its output relayed to the parent process (e.g. Steam)... but what's actually happening is through
jourald, we peek at the output ofsteamos-manager.service(filtering on the syslog identifier)...steamos-managerwas asked to do the it through a simple dbus call.Simply that.
Enhancements required
Prevent running against block device with mounted storage
On some of Jovian Experiment's users' systems, it's been observed that the block device where the rootfs resides is showing up in Steam as an option to target and attempt to format.
This uh... could lead to unfun results... but wasn't tried.
Unsure at which end it should happen, but checks should be made so the script fails early if the block device has any "mounted" partitions (which includes swap too).
TODO