Fix/value changes #1408
Open
Fix/value changes #1408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apply the same value to native element as what is applied to the form control when formControl.setValue is called. Log a warning and optionally return a validation error.
…rors. Do not attempt to interpret !_justPased and !_code as setValueTriggered
|
@MattKuhn123 Hi. Please resolve merge conflicts |
…x/valueChanges
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
When a formControl's value is set programmatically with a value that doesn't fit the mask, then the value displayed in the element won't match what the programmer was expecting.
Issue Number: 1372
What is the new behavior?
To help the programmer understand what is going on, detect if there was a fault with the mask application. If a fault was detected, log a warning in the console, and display the programmatically-set value in the element.
Does this PR introduce a breaking change?
Other information