MA.operate!(+, pol1, pol2): prevent captured variable perf issue
#145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The local function was spuriously recursive, making it not recursive fixes the performance problem. That is, this removes some run time dispatch and decreases the amount of allocation, but there's still some run time dispatch left in other places, according to JET.jl. Before: ```julia-repl julia> import MutableArithmetics; const MA = MutableArithmetics; julia> using DynamicPolynomials julia> @PolyVar x y; julia> p = 2x + y; julia> q = x + 2y; julia> @allocated MA.operate!(+, p, q) 34413936 ``` After: ```julia-repl julia> import MutableArithmetics; const MA = MutableArithmetics; julia> using DynamicPolynomials julia> @PolyVar x y; julia> p = 2x + y; julia> q = x + 2y; julia> @allocated MA.operate!(+, p, q) 30835632 ``` Both REPL runs was with nightly Julia v1.11.
|
It seems the issue is that |
|
Not sure why you think that? Have you checked with Cthulhu or something? The issue that I fixed in this PR is a standard performance of captured variables issue, where the closure is itself the captured variable, so making it nonrecursive prevents boxing, as far as I understand. |
blegat
approved these changes
Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The local function was spuriously recursive, making it not recursive fixes the performance problem. That is, this removes some run time dispatch and decreases the amount of allocation, but there's still some run time dispatch left in other places, according to JET.jl.
Before:
After:
Both REPL runs was with nightly Julia v1.11.