Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix evaluation for arrayspace #287

Merged
merged 2 commits into from
Nov 24, 2022
Merged

Fix evaluation for arrayspace #287

merged 2 commits into from
Nov 24, 2022

Conversation

jishnub
Copy link
Member

@jishnub jishnub commented Nov 23, 2022

Fix #286 partly. After this,

julia> f = Fun(x -> Float64[1, 2])
Fun(2-element ArraySpace:
[Chebyshev(), Chebyshev()], [1.0, 2.0])

julia> Evaluation(0.5)*f
[1.0, 2.0] on Point(0.5)

@codecov
Copy link

codecov bot commented Nov 23, 2022 •
edited
Loading

Codecov Report

Base: 70.62% // Head: 71.32% // Increases project coverage by +0.69% 🎉

Coverage data is based on head (62f064a) compared to base (45a7d48).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #287      +/-   ##
==========================================
+ Coverage   70.62%   71.32%   +0.69%     
==========================================
  Files          78       78              
  Lines        8116     8121       +5     
==========================================
+ Hits         5732     5792      +60     
+ Misses       2384     2329      -55
Impacted Files Coverage Δ
src/Operators/functionals/Evaluation.jl 88.75% <100.00%> (+0.14%) ⬆️
src/show.jl 98.44% <100.00%> (+0.84%) ⬆️
src/Caching/ragged.jl 62.68% <0.00%> (-1.00%) ⬇️
src/Operators/general/InterlaceOperator.jl 86.45% <0.00%> (+0.34%) ⬆️
src/Caching/almostbanded.jl 97.89% <0.00%> (+0.35%) ⬆️
src/PDE/KroneckerOperator.jl 78.83% <0.00%> (+0.41%) ⬆️
src/LinearAlgebra/helper.jl 64.15% <0.00%> (+0.45%) ⬆️
src/LinearAlgebra/clenshaw.jl 39.47% <0.00%> (+0.52%) ⬆️
src/Multivariate/LowRankFun.jl 68.70% <0.00%> (+0.76%) ⬆️
... and 21 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jishnub jishnub merged commit b110ff2 into JuliaApproximation:master Nov 24, 2022
@jishnub jishnub deleted the arrayspeval branch November 24, 2022 04:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Evaluation operator does not work with ArraySpaces
1 participant
@jishnub