Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should boundary(::Rectangle) use simpler types? #142

Closed
dlfivefifty opened this issue Oct 7, 2023 · 2 comments
Closed

Should boundary(::Rectangle) use simpler types? #142

dlfivefifty opened this issue Oct 7, 2023 · 2 comments

Comments

@dlfivefifty
Copy link
Member

I'm wondering if it would be more natural to have a notion of a rectangle embedded in a higher dimensional space rather than representing them as affine mapped rectangles... eg I would have expected the boundary of a 2D rectangle to be a union of LineSegments instead of affine mapped unit intervals.

I guess the two definitions are equivalent so maybe its just a question of making a type alias with prettier printing? That is, we could have LineSegment(a,b) create an affine mapped interval.

@daanhb
Copy link
Member

daanhb commented Oct 9, 2023

Sure, we could have an alias. It would be good to have more general faces and edges etcetera, but of course multiple other packages provide that. I'd like to get #141 out of the way so that we can move on, I have some code depending on it in the meantime so I'll merge and fix any issues that arise.

@daanhb
Copy link
Member

daanhb commented Feb 17, 2024

Dup of #100

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants