Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve support for boundary, gradient and normal #83

Closed
daanhb opened this issue Jun 4, 2021 · 1 comment
Closed

improve support for boundary, gradient and normal #83

daanhb opened this issue Jun 4, 2021 · 1 comment

Comments

@daanhb
Copy link
Member

daanhb commented Jun 4, 2021

Some domains already define the boundary function, e.g., the boundary of the unit disk is the unit circle. It would be good to extend this to all domains that can be used in geometry. At the same time, we can define gradients and normal directions when they make sense.

Right now we have

julia> using DomainSets; boundary(UnitCube())
D₄  D₂  D₃

D₁ = Point{Float64}(0.0)  Point{Float64}(1.0)
D₂ = (0.0..1.0 (Unit)) × D₁ × (0.0..1.0 (Unit))
D₃ = (0.0..1.0 (Unit)) × (0.0..1.0 (Unit)) × D₁
D₄ = D₁ × (0.0..1.0 (Unit)) × (0.0..1.0 (Unit))

This is not wrong, but it may be better to support hyperfaces, so that the boundary of all polytopes can be a collection of hyperfaces (of the same type).

@daanhb
Copy link
Member Author

daanhb commented Oct 5, 2021

Closing in favour of #100

@daanhb daanhb closed this as completed Oct 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant